bug: only change user to system if there is just one message

ibuildthecloud · ibuildthecloud · commit d0b86905c5cb · 2024-05-15T11:00:15.000-07:00
diff --git a/pkg/openai/client.go b/pkg/openai/client.go
@@ -238,12 +238,9 @@ func toMessages(request types.CompletionRequest) (result []openai.ChatCompletion
 		})
 	}
 
-	// Never send only a system message or a system message not followed by a user message
-	if len(msgs) > 0 && msgs[0].Role == types.CompletionMessageRoleTypeSystem {
-		if len(msgs) == 1 ||
-			(len(msgs) > 1 && msgs[1].Role != types.CompletionMessageRoleTypeUser) {
-			msgs[0].Role = types.CompletionMessageRoleTypeUser
-		}
+	// Never send only a system message
+	if len(msgs) == 1 && msgs[0].Role == types.CompletionMessageRoleTypeSystem {
+		msgs[0].Role = types.CompletionMessageRoleTypeUser
 	}
 
 	for _, message := range msgs {

Original file line number	Diff line number	Diff line change
`@@ -238,12 +238,9 @@ func toMessages(request types.CompletionRequest) (result []openai.ChatCompletion`
`238`	`238`	`})`
`239`	`239`	`}`
`240`	`240`
`241`		`- // Never send only a system message or a system message not followed by a user message`
`242`		`- if len(msgs) > 0 && msgs[0].Role == types.CompletionMessageRoleTypeSystem {`
`243`		`- if len(msgs) == 1 \|\|`
`244`		`- (len(msgs) > 1 && msgs[1].Role != types.CompletionMessageRoleTypeUser) {`
`245`		`- msgs[0].Role = types.CompletionMessageRoleTypeUser`
`246`		`- }`
	`241`	`+ // Never send only a system message`
	`242`	`+ if len(msgs) == 1 && msgs[0].Role == types.CompletionMessageRoleTypeSystem {`
	`243`	`+ msgs[0].Role = types.CompletionMessageRoleTypeUser`
`247`	`244`	`}`
`248`	`245`
`249`	`246`	`for _, message := range msgs {`