Skip to content

bug: check for very specific #! on line 1 #310

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 3, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 25 additions & 1 deletion pkg/parser/parser.go
Original file line number Diff line number Diff line change
Expand Up @@ -339,6 +339,30 @@ func Parse(input io.Reader, opts ...Options) (Document, error) {
}, nil
}

func isGPTScriptHashBang(line string) bool {
if !strings.HasPrefix(line, "#!") {
return false
}

parts := strings.Fields(line)

// Very specific lines we are looking for
// 1. #!gptscript
// 2. #!/usr/bin/env gptscript
// 3. #!/bin/env gptscript

if parts[0] == "#!gptscript" {
return true
}

if len(parts) > 1 && (parts[0] == "#!/usr/bin/env" || parts[0] == "#!/bin/env") &&
parts[1] == "gptscript" {
return true
}

return false
}

func parse(input io.Reader) ([]Node, error) {
scan := bufio.NewScanner(input)

Expand Down Expand Up @@ -373,7 +397,7 @@ func parse(input io.Reader) ([]Node, error) {

if !context.inBody {
// If the very first line is #! just skip because this is a unix interpreter declaration
if strings.HasPrefix(line, "#!") && lineNo == 1 {
if lineNo == 1 && isGPTScriptHashBang(line) {
continue
}

Expand Down
14 changes: 14 additions & 0 deletions pkg/parser/parser_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,20 @@ import (
"github.com/stretchr/testify/require"
)

func TestHashBang(t *testing.T) {
autogold.Expect(true).Equal(t, isGPTScriptHashBang("#!/usr/bin/env gptscript"))
autogold.Expect(true).Equal(t, isGPTScriptHashBang("#!/bin/env gptscript"))
autogold.Expect(true).Equal(t, isGPTScriptHashBang("#!gptscript"))

autogold.Expect(false).Equal(t, isGPTScriptHashBang("/usr/bin/env gptscript"))
autogold.Expect(false).Equal(t, isGPTScriptHashBang("/bin/env gptscript"))
autogold.Expect(false).Equal(t, isGPTScriptHashBang("gptscript"))

autogold.Expect(false).Equal(t, isGPTScriptHashBang("#!/sr/bin/env gptscript"))
autogold.Expect(false).Equal(t, isGPTScriptHashBang("#!/bin/env gpscript"))
autogold.Expect(false).Equal(t, isGPTScriptHashBang("#!gptscrip"))
}

func TestParseGlobals(t *testing.T) {
var input = `
global tools: foo, bar
Expand Down