Merge pull request #100 from sschuberth/address-inspection-hints

Address inspection hints

Author: bigdaz

plugin/src/main/kotlin/org/gradle/dependencygraph/AbstractDependencyExtractorPlugin.kt

@@ -20,7 +20,7 @@ abstract class AbstractDependencyExtractorPlugin : Plugin<Gradle> {
      */
     abstract fun getRendererClassName(): String
 
-    internal lateinit var dependencyExtractorProvider: Provider<out DependencyExtractor>
+    private lateinit var dependencyExtractorProvider: Provider<out DependencyExtractor>
 
     override fun apply(gradle: Gradle) {
         val gradleVersion = GradleVersion.current()

plugin/src/main/kotlin/org/gradle/dependencygraph/extractor/DependencyExtractor.kt

@@ -156,7 +156,7 @@ abstract class DependencyExtractor :
         val rootPath = projectIdentityPath ?: details.buildPath
 
         if (!configurationFilter.include(rootPath, details.configurationName)) {
-            LOGGER.debug("Ignoring resolved configuration: ${rootPath} - ${details.configurationName}")
+            LOGGER.debug("Ignoring resolved configuration: $rootPath - ${details.configurationName}")
             return
         }
 

plugin/src/main/kotlin/org/gradle/dependencygraph/extractor/ResolvedConfigurationFilter.kt

@@ -1,8 +1,8 @@
 package org.gradle.dependencygraph.extractor
 
 class ResolvedConfigurationFilter(projectFilter: String?, configurationFilter: String?) {
-    val projectRegex = projectFilter?.toRegex()
-    val configurationRegex = configurationFilter?.toRegex()
+    private val projectRegex = projectFilter?.toRegex()
+    private val configurationRegex = configurationFilter?.toRegex()
 
     fun include(projectPath: String, configurationName: String): Boolean {
         if (projectRegex != null && !projectRegex.matches(projectPath)) {

plugin/src/main/kotlin/org/gradle/dependencygraph/simple/SimpleDependencyGraphPlugin.kt

@@ -4,7 +4,6 @@ import org.gradle.api.Plugin
 import org.gradle.api.invocation.Gradle
 import org.gradle.dependencygraph.AbstractDependencyExtractorPlugin
 import org.gradle.forceresolve.ForceDependencyResolutionPlugin
-import org.gradle.github.GitHubDependencyExtractorPlugin
 
 @Suppress("unused")
 class SimpleDependencyGraphPlugin : Plugin<Gradle> {

plugin/src/main/kotlin/org/gradle/dependencygraph/util/GradleExtensions.kt

@@ -7,10 +7,6 @@ import org.gradle.api.provider.ProviderFactory
 import org.gradle.internal.operations.BuildOperationListenerManager
 
 internal abstract class GradleExtensions {
-
-    inline val Gradle.objectFactory: ObjectFactory
-        get() = service()
-
     inline val Gradle.providerFactory: ProviderFactory
         get() = service()
 

plugin/src/main/kotlin/org/gradle/github/dependencygraph/GitHubDependencyGraphRenderer.kt

@@ -8,7 +8,7 @@ import org.gradle.dependencygraph.model.ResolvedConfiguration
 import org.gradle.dependencygraph.util.*
 import java.io.File
 
-class GitHubDependencyGraphRenderer() : DependencyGraphRenderer {
+class GitHubDependencyGraphRenderer : DependencyGraphRenderer {
 
     override fun outputDependencyGraph(
         pluginParameters: PluginParameters,

plugin/src/main/kotlin/org/gradle/github/dependencygraph/GitHubSnapshotParams.kt

@@ -14,7 +14,7 @@ const val PARAM_GITHUB_SHA = "GITHUB_DEPENDENCY_GRAPH_SHA"
  */
 const val PARAM_GITHUB_WORKSPACE = "GITHUB_DEPENDENCY_GRAPH_WORKSPACE"
 
-class GitHubSnapshotParams(private val pluginParameters: PluginParameters) {
+class GitHubSnapshotParams(pluginParameters: PluginParameters) {
     val dependencyGraphJobCorrelator: String = pluginParameters.load(PARAM_JOB_CORRELATOR)
     val dependencyGraphJobId: String =pluginParameters.load(PARAM_JOB_ID)
     val gitSha: String = pluginParameters.load(PARAM_GITHUB_SHA)