Merge pull request #813 from APIs-guru/uniq_union

Forbid to define duplicated member types in Union

Author: leebyron

src/type/__tests__/validation-test.js

@@ -637,6 +637,19 @@ describe('Type System: Union types must be array', () => {
     );
   });
 
+  it('rejects a Union type with duplicated member type', () => {
+    expect(
+      () => schemaWithFieldType(new GraphQLUnionType({
+        name: 'SomeUnion',
+        resolveType: () => null,
+        types: [
+          SomeObjectType,
+          SomeObjectType,
+        ],
+      }))
+    ).to.throw('SomeUnion can include SomeObject type only once.');
+  });
+
 });
 
 

src/type/definition.js

@@ -789,12 +789,18 @@ function defineTypes(
     'Must provide Array of types or a function which returns ' +
     `such an array for Union ${unionType.name}.`
   );
+  const includedTypeNames = {};
   types.forEach(objType => {
     invariant(
       objType instanceof GraphQLObjectType,
       `${unionType.name} may only contain Object types, it cannot contain: ` +
       `${String(objType)}.`
     );
+    invariant(
+      !includedTypeNames[objType.name],
+      `${unionType.name} can include ${objType.name} type only once.`
+    );
+    includedTypeNames[objType.name] = true;
     if (typeof unionType.resolveType !== 'function') {
       invariant(
         typeof objType.isTypeOf === 'function',