fix elasticsearch errors being mistaken for graphql errors (#1090)

Author: trevorah

src/error/__tests__/locatedError-test.js

@@ -0,0 +1,47 @@
+/**
+ * Copyright (c) 2015-present, Facebook, Inc.
+ *
+ * This source code is licensed under the MIT license found in the
+ * LICENSE file in the root directory of this source tree.
+ */
+
+import { expect } from 'chai';
+import { describe, it } from 'mocha';
+
+import { GraphQLError } from '../../';
+import { locatedError } from '../locatedError';
+
+describe('locatedError', () => {
+
+  it('passes GraphQLError through', () => {
+    const e = new GraphQLError(
+      'msg',
+      null,
+      null,
+      null,
+      [ 'path', 3, 'to', 'field' ]
+    );
+
+    expect(locatedError(e, [], [])).to.deep.equal(e);
+  });
+
+  it('passes GraphQLError-ish through', () => {
+    const e = new Error('I have a different prototype chain');
+    e.locations = [];
+    e.path = [];
+    e.nodes = [];
+    e.source = null;
+    e.positions = [];
+    e.name = 'GraphQLError';
+
+    expect(locatedError(e, [], [])).to.deep.equal(e);
+  });
+
+  it('does not pass through elasticsearch-like errors', () => {
+    const e = new Error('I am from elasticsearch');
+    e.path = '/something/feed/_search';
+
+    expect(locatedError(e, [], [])).to.not.deep.equal(e);
+  });
+
+});

src/error/locatedError.js

@@ -22,7 +22,7 @@ export function locatedError(
 ): GraphQLError {
   // Note: this uses a brand-check to support GraphQL errors originating from
   // other contexts.
-  if (originalError && originalError.path) {
+  if (originalError && Array.isArray(originalError.path)) {
     return (originalError: any);
   }