Simplify args definition (#1650)

Author: IvanGoncharov

src/type/definition.js

@@ -728,23 +728,20 @@ function defineFieldMap<TSource, TContext>(
       `${config.name}.${fieldName} field resolver must be a function if ` +
         `provided, but got: ${inspect(field.resolve)}.`,
     );
-    const argsConfig = fieldConfig.args;
-    if (!argsConfig) {
-      field.args = [];
-    } else {
-      invariant(
-        isPlainObj(argsConfig),
-        `${config.name}.${fieldName} args must be an object with argument ` +
-          'names as keys.',
-      );
-      field.args = objectEntries(argsConfig).map(([argName, arg]) => ({
-        name: argName,
-        description: arg.description === undefined ? null : arg.description,
-        type: arg.type,
-        defaultValue: arg.defaultValue,
-        astNode: arg.astNode,
-      }));
-    }
+    const argsConfig = fieldConfig.args || {};
+    invariant(
+      isPlainObj(argsConfig),
+      `${config.name}.${fieldName} args must be an object with argument ` +
+        'names as keys.',
+    );
+
+    field.args = objectEntries(argsConfig).map(([argName, arg]) => ({
+      name: argName,
+      description: arg.description === undefined ? null : arg.description,
+      type: arg.type,
+      defaultValue: arg.defaultValue,
+      astNode: arg.astNode,
+    }));
     resultFieldMap[fieldName] = field;
   }
   return resultFieldMap;

src/type/directives.js

@@ -66,23 +66,19 @@ export class GraphQLDirective {
       'Must provide locations for directive.',
     );
 
-    const args = config.args;
-    if (!args) {
-      this.args = [];
-    } else {
-      invariant(
-        !Array.isArray(args),
-        `@${config.name} args must be an object with argument names as keys.`,
-      );
-
-      this.args = objectEntries(args).map(([argName, arg]) => ({
-        name: argName,
-        description: arg.description === undefined ? null : arg.description,
-        type: arg.type,
-        defaultValue: arg.defaultValue,
-        astNode: arg.astNode,
-      }));
-    }
+    const args = config.args || {};
+    invariant(
+      !Array.isArray(args),
+      `@${config.name} args must be an object with argument names as keys.`,
+    );
+
+    this.args = objectEntries(args).map(([argName, arg]) => ({
+      name: argName,
+      description: arg.description === undefined ? null : arg.description,
+      type: arg.type,
+      defaultValue: arg.defaultValue,
+      astNode: arg.astNode,
+    }));
   }
 
   toString(): string {