Skip to content

Commit 9e40465

Browse files
Move polyfills into separate dir and exclude them from coverage (#1656)
1 parent 46dc163 commit 9e40465

26 files changed

+36
-27
lines changed

.nycrc

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
{
22
"include": ["src/"],
3-
"exclude": [],
3+
"exclude": ["src/polyfills"],
44
"temp-directory": "coverage"
55
}

src/execution/values.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,8 +7,8 @@
77
* @flow strict
88
*/
99

10+
import find from '../polyfills/find';
1011
import { GraphQLError } from '../error/GraphQLError';
11-
import find from '../jsutils/find';
1212
import inspect from '../jsutils/inspect';
1313
import invariant from '../jsutils/invariant';
1414
import keyMap from '../jsutils/keyMap';

src/jsutils/mapValue.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@
88
*/
99

1010
import type { ObjMap } from './ObjMap';
11-
import objectEntries from './objectEntries';
11+
import objectEntries from '../polyfills/objectEntries';
1212

1313
/**
1414
* Creates an object map with the same keys as `map` and values generated by

src/polyfills/README.md

Lines changed: 9 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,9 @@
1+
Polyfills
2+
---------
3+
4+
This directory contains dependency-free polyfills for ES6 & ES7 functions used
5+
throughout the codebase.
6+
7+
Each polyfill should belong in its own file and be the default export.
8+
9+
These functions are not part of the module interface and are subject to change.
File renamed without changes.
File renamed without changes.
File renamed without changes.

src/jsutils/objectEntries.js renamed to src/polyfills/objectEntries.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@
77
* @flow strict
88
*/
99

10-
import type { ObjMap } from './ObjMap';
10+
import type { ObjMap } from '../jsutils/ObjMap';
1111

1212
declare function objectEntries<T>(obj: ObjMap<T>): Array<[string, T]>;
1313

src/jsutils/objectValues.js renamed to src/polyfills/objectValues.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@
77
* @flow strict
88
*/
99

10-
import type { ObjMap } from './ObjMap';
10+
import type { ObjMap } from '../jsutils/ObjMap';
1111

1212
declare function objectValues<T>(obj: ObjMap<T>): Array<T>;
1313

src/type/definition.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,6 +7,7 @@
77
* @flow strict
88
*/
99

10+
import objectEntries from '../polyfills/objectEntries';
1011
import defineToJSON from '../jsutils/defineToJSON';
1112
import defineToStringTag from '../jsutils/defineToStringTag';
1213
import instanceOf from '../jsutils/instanceOf';
@@ -15,7 +16,6 @@ import invariant from '../jsutils/invariant';
1516
import keyMap from '../jsutils/keyMap';
1617
import mapValue from '../jsutils/mapValue';
1718
import type { ObjMap } from '../jsutils/ObjMap';
18-
import objectEntries from '../jsutils/objectEntries';
1919
import { Kind } from '../language/kinds';
2020
import { valueFromASTUntyped } from '../utilities/valueFromASTUntyped';
2121
import type {

src/type/directives.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,6 +7,7 @@
77
* @flow strict
88
*/
99

10+
import objectEntries from '../polyfills/objectEntries';
1011
import type {
1112
GraphQLFieldConfigArgumentMap,
1213
GraphQLArgument,
@@ -18,7 +19,6 @@ import defineToJSON from '../jsutils/defineToJSON';
1819
import instanceOf from '../jsutils/instanceOf';
1920
import invariant from '../jsutils/invariant';
2021
import inspect from '../jsutils/inspect';
21-
import objectEntries from '../jsutils/objectEntries';
2222
import type { DirectiveDefinitionNode } from '../language/ast';
2323
import {
2424
DirectiveLocation,

src/type/introspection.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,8 +7,8 @@
77
* @flow strict
88
*/
99

10+
import objectValues from '../polyfills/objectValues';
1011
import isInvalid from '../jsutils/isInvalid';
11-
import objectValues from '../jsutils/objectValues';
1212
import { astFromValue } from '../utilities/astFromValue';
1313
import { print } from '../language/printer';
1414
import {

src/type/scalars.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -7,9 +7,9 @@
77
* @flow strict
88
*/
99

10+
import isFinite from '../polyfills/isFinite';
11+
import isInteger from '../polyfills/isInteger';
1012
import inspect from '../jsutils/inspect';
11-
import isFinite from '../jsutils/isFinite';
12-
import isInteger from '../jsutils/isInteger';
1313
import { GraphQLScalarType, isNamedType } from './definition';
1414
import { Kind } from '../language/kinds';
1515

src/type/schema.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -7,6 +7,8 @@
77
* @flow strict
88
*/
99

10+
import find from '../polyfills/find';
11+
import objectValues from '../polyfills/objectValues';
1012
import {
1113
isAbstractType,
1214
isObjectType,
@@ -34,10 +36,8 @@ import type { GraphQLError } from '../error/GraphQLError';
3436
import inspect from '../jsutils/inspect';
3537
import { __Schema } from './introspection';
3638
import defineToStringTag from '../jsutils/defineToStringTag';
37-
import find from '../jsutils/find';
3839
import instanceOf from '../jsutils/instanceOf';
3940
import invariant from '../jsutils/invariant';
40-
import objectValues from '../jsutils/objectValues';
4141
import type { ObjMap } from '../jsutils/ObjMap';
4242

4343
/**

src/type/validate.js

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -7,6 +7,9 @@
77
* @flow strict
88
*/
99

10+
import find from '../polyfills/find';
11+
import objectValues from '../polyfills/objectValues';
12+
import objectEntries from '../polyfills/objectEntries';
1013
import {
1114
isObjectType,
1215
isInterfaceType,
@@ -31,9 +34,6 @@ import { isIntrospectionType } from './introspection';
3134
import { assertSchema } from './schema';
3235
import type { GraphQLSchema } from './schema';
3336
import inspect from '../jsutils/inspect';
34-
import find from '../jsutils/find';
35-
import objectValues from '../jsutils/objectValues';
36-
import objectEntries from '../jsutils/objectEntries';
3737
import { GraphQLError } from '../error/GraphQLError';
3838
import type {
3939
ASTNode,

src/utilities/TypeInfo.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,6 +7,7 @@
77
* @flow strict
88
*/
99

10+
import find from '../polyfills/find';
1011
import { Kind } from '../language/kinds';
1112
import {
1213
isObjectType,
@@ -39,7 +40,6 @@ import {
3940
import type { GraphQLSchema } from '../type/schema';
4041
import type { ASTNode, FieldNode } from '../language/ast';
4142
import { typeFromAST } from './typeFromAST';
42-
import find from '../jsutils/find';
4343

4444
/**
4545
* TypeInfo is a utility class which, given a GraphQL schema, can keep track

src/utilities/astFromValue.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,10 +9,10 @@
99

1010
import { forEach, isCollection } from 'iterall';
1111

12+
import objectValues from '../polyfills/objectValues';
1213
import inspect from '../jsutils/inspect';
1314
import isNullish from '../jsutils/isNullish';
1415
import isInvalid from '../jsutils/isInvalid';
15-
import objectValues from '../jsutils/objectValues';
1616
import type { ValueNode } from '../language/ast';
1717
import { Kind } from '../language/kinds';
1818
import type { GraphQLInputType } from '../type/definition';

src/utilities/buildASTSchema.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,10 +7,10 @@
77
* @flow strict
88
*/
99

10+
import objectValues from '../polyfills/objectValues';
1011
import invariant from '../jsutils/invariant';
1112
import keyMap from '../jsutils/keyMap';
1213
import keyValMap from '../jsutils/keyValMap';
13-
import objectValues from '../jsutils/objectValues';
1414
import type { ObjMap } from '../jsutils/ObjMap';
1515
import { valueFromAST } from './valueFromAST';
1616
import { assertValidSDL } from '../validation/validate';

src/utilities/coerceValue.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,10 +8,10 @@
88
*/
99

1010
import { forEach, isCollection } from 'iterall';
11+
import objectValues from '../polyfills/objectValues';
1112
import inspect from '../jsutils/inspect';
1213
import isInvalid from '../jsutils/isInvalid';
1314
import orList from '../jsutils/orList';
14-
import objectValues from '../jsutils/objectValues';
1515
import suggestionList from '../jsutils/suggestionList';
1616
import { GraphQLError } from '../error/GraphQLError';
1717
import type { ASTNode } from '../language/ast';

src/utilities/extendSchema.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,10 +7,10 @@
77
* @flow strict
88
*/
99

10+
import objectValues from '../polyfills/objectValues';
1011
import invariant from '../jsutils/invariant';
1112
import mapValue from '../jsutils/mapValue';
1213
import keyValMap from '../jsutils/keyValMap';
13-
import objectValues from '../jsutils/objectValues';
1414
import { ASTDefinitionBuilder } from './buildASTSchema';
1515
import { assertValidSDLExtension } from '../validation/validate';
1616
import { assertSchema, GraphQLSchema } from '../type/schema';

src/utilities/findBreakingChanges.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,6 +7,7 @@
77
* @flow strict
88
*/
99

10+
import find from '../polyfills/find';
1011
import {
1112
isScalarType,
1213
isObjectType,
@@ -30,7 +31,6 @@ import type {
3031

3132
import type { GraphQLDirective } from '../type/directives';
3233
import type { GraphQLSchema } from '../type/schema';
33-
import find from '../jsutils/find';
3434
import keyMap from '../jsutils/keyMap';
3535

3636
import type { ObjMap } from '../jsutils/ObjMap';

src/utilities/lexicographicSortSchema.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,9 +7,9 @@
77
* @flow strict
88
*/
99

10+
import objectValues from '../polyfills/objectValues';
1011
import type { ObjMap } from '../jsutils/ObjMap';
1112
import keyValMap from '../jsutils/keyValMap';
12-
import objectValues from '../jsutils/objectValues';
1313
import { GraphQLSchema } from '../type/schema';
1414
import { GraphQLDirective } from '../type/directives';
1515
import type { GraphQLNamedType } from '../type/definition';

src/utilities/schemaPrinter.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,9 +7,9 @@
77
* @flow strict
88
*/
99

10+
import objectValues from '../polyfills/objectValues';
1011
import isNullish from '../jsutils/isNullish';
1112
import isInvalid from '../jsutils/isInvalid';
12-
import objectValues from '../jsutils/objectValues';
1313
import { astFromValue } from '../utilities/astFromValue';
1414
import { print } from '../language/printer';
1515
import type { GraphQLSchema } from '../type/schema';

src/utilities/valueFromAST.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,9 +7,9 @@
77
* @flow strict
88
*/
99

10+
import objectValues from '../polyfills/objectValues';
1011
import keyMap from '../jsutils/keyMap';
1112
import isInvalid from '../jsutils/isInvalid';
12-
import objectValues from '../jsutils/objectValues';
1313
import type { ObjMap } from '../jsutils/ObjMap';
1414
import { Kind } from '../language/kinds';
1515
import {

src/validation/rules/OverlappingFieldsCanBeMerged.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -7,12 +7,12 @@
77
* @flow strict
88
*/
99

10+
import find from '../../polyfills/find';
11+
import objectEntries from '../../polyfills/objectEntries';
1012
import type { ValidationContext } from '../ValidationContext';
1113
import { GraphQLError } from '../../error/GraphQLError';
1214
import inspect from '../../jsutils/inspect';
13-
import find from '../../jsutils/find';
1415
import type { ObjMap } from '../../jsutils/ObjMap';
15-
import objectEntries from '../../jsutils/objectEntries';
1616
import type {
1717
SelectionSetNode,
1818
FieldNode,

src/validation/rules/ValuesOfCorrectType.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,6 +7,7 @@
77
* @flow strict
88
*/
99

10+
import objectValues from '../../polyfills/objectValues';
1011
import type { ValidationContext } from '../ValidationContext';
1112
import { GraphQLError } from '../../error/GraphQLError';
1213
import type { ValueNode } from '../../language/ast';
@@ -27,7 +28,6 @@ import inspect from '../../jsutils/inspect';
2728
import isInvalid from '../../jsutils/isInvalid';
2829
import keyMap from '../../jsutils/keyMap';
2930
import orList from '../../jsutils/orList';
30-
import objectValues from '../../jsutils/objectValues';
3131
import suggestionList from '../../jsutils/suggestionList';
3232

3333
export function badValueMessage(

0 commit comments

Comments
 (0)