Handle NaN as input value (#1369)

Author: IvanGoncharov

src/type/definition.js

@@ -11,7 +11,6 @@ import applyToStringTag from '../jsutils/applyToStringTag';
 import instanceOf from '../jsutils/instanceOf';
 import inspect from '../jsutils/inspect';
 import invariant from '../jsutils/invariant';
-import isInvalid from '../jsutils/isInvalid';
 import keyMap from '../jsutils/keyMap';
 import type { ObjMap } from '../jsutils/ObjMap';
 import { Kind } from '../language/kinds';
@@ -566,9 +565,6 @@ export class GraphQLScalarType {
   // Parses an externally provided value to use as an input.
   parseValue(value: mixed): mixed {
     const parser = this._scalarConfig.parseValue;
-    if (isInvalid(value)) {
-      return undefined;
-    }
     return parser ? parser(value) : value;
   }
 

src/utilities/__tests__/coerceValue-test.js

@@ -83,6 +83,13 @@ describe('coerceValue', () => {
       ]);
     });
 
+    it('returns a single error for NaN input as int', () => {
+      const result = coerceValue(NaN, GraphQLInt);
+      expectErrors(result).to.deep.equal([
+        'Expected type Int; Int cannot represent non-integer value: NaN',
+      ]);
+    });
+
     it('returns a single error for Infinity input as int', () => {
       const result = coerceValue(Infinity, GraphQLInt);
       expectErrors(result).to.deep.equal([
@@ -133,6 +140,13 @@ describe('coerceValue', () => {
       ]);
     });
 
+    it('returns a single error for NaN input', () => {
+      const result = coerceValue(NaN, GraphQLFloat);
+      expectErrors(result).to.deep.equal([
+        'Expected type Float; Float cannot represent non numeric value: NaN',
+      ]);
+    });
+
     it('returns a single error for Infinity input', () => {
       const result = coerceValue(Infinity, GraphQLFloat);
       expectErrors(result).to.deep.equal([

src/utilities/coerceValue.js

@@ -10,7 +10,6 @@
 import { forEach, isCollection } from 'iterall';
 import inspect from '../jsutils/inspect';
 import isInvalid from '../jsutils/isInvalid';
-import isNullish from '../jsutils/isNullish';
 import orList from '../jsutils/orList';
 import suggestionList from '../jsutils/suggestionList';
 import { GraphQLError } from '../error';
@@ -46,7 +45,7 @@ export function coerceValue(
 ): CoercedValue {
   // A value must be provided if the type is non-null.
   if (isNonNullType(type)) {
-    if (isNullish(value)) {
+    if (value == null) {
       return ofErrors([
         coercionError(
           `Expected non-nullable type ${inspect(type)} not to be null`,
@@ -58,7 +57,7 @@ export function coerceValue(
     return coerceValue(value, type.ofType, blameNode, path);
   }
 
-  if (isNullish(value)) {
+  if (value == null) {
     // Explicitly return the value null.
     return ofValue(null);
   }