Skip to content

Commit bb07ecc

Browse files
Remove useless check since args are always array (can be empty) (#2049)
1 parent 670bbac commit bb07ecc

File tree

2 files changed

+4
-6
lines changed

2 files changed

+4
-6
lines changed

src/execution/values.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -124,11 +124,11 @@ export function getArgumentValues(
124124
variableValues?: ?ObjMap<mixed>,
125125
): { [argument: string]: mixed, ... } {
126126
const coercedValues = {};
127-
const argDefs = def.args;
128127
const argNodes = node.arguments;
129-
if (!argDefs || !argNodes) {
128+
if (!argNodes) {
130129
return coercedValues;
131130
}
131+
const argDefs = def.args;
132132
const argNodeMap = keyMap(argNodes, arg => arg.name.value);
133133
for (let i = 0; i < argDefs.length; i++) {
134134
const argDef = argDefs[i];

src/type/schema.js

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -352,10 +352,8 @@ function typeMapReducer(map: TypeMap, type: ?GraphQLType): TypeMap {
352352

353353
if (isObjectType(type) || isInterfaceType(type)) {
354354
for (const field of objectValues(type.getFields())) {
355-
if (field.args) {
356-
const fieldArgTypes = field.args.map(arg => arg.type);
357-
reducedMap = fieldArgTypes.reduce(typeMapReducer, reducedMap);
358-
}
355+
const fieldArgTypes = field.args.map(arg => arg.type);
356+
reducedMap = fieldArgTypes.reduce(typeMapReducer, reducedMap);
359357
reducedMap = typeMapReducer(reducedMap, field.type);
360358
}
361359
}

0 commit comments

Comments
 (0)