Apply "UniqueDirectivesPerLocation" to SDL

Author: IvanGoncharov

src/validation/__tests__/UniqueDirectivesPerLocation-test.js

@@ -6,12 +6,22 @@
  */
 
 import { describe, it } from 'mocha';
-import { expectPassesRule, expectFailsRule } from './harness';
+import {
+  expectPassesRule,
+  expectFailsRule,
+  expectSDLErrorsFromRule,
+} from './harness';
+
 import {
   UniqueDirectivesPerLocation,
   duplicateDirectiveMessage,
 } from '../rules/UniqueDirectivesPerLocation';
 
+const expectSDLErrors = expectSDLErrorsFromRule.bind(
+  undefined,
+  UniqueDirectivesPerLocation,
+);
+
 function duplicateDirective(directiveName, l1, c1, l2, c2) {
   return {
     message: duplicateDirectiveMessage(directiveName),
@@ -132,4 +142,39 @@ describe('Validate: Directives Are Unique Per Location', () => {
       ],
     );
   });
+
+  it('duplicate directives on SDL definitions', () => {
+    expectSDLErrors(`
+      schema @directive @directive { query: Dummy }
+      extend schema @directive @directive
+
+      scalar TestScalar @directive @directive
+      extend scalar TestScalar @directive @directive
+
+      type TestObject @directive @directive
+      extend type TestObject @directive @directive
+
+      interface TestInterface @directive @directive
+      extend interface TestInterface @directive @directive
+
+      union TestUnion @directive @directive
+      extend union TestUnion @directive @directive
+
+      input TestInput @directive @directive
+      extend input TestInput @directive @directive
+    `).to.deep.equal([
+      duplicateDirective('directive', 2, 14, 2, 25),
+      duplicateDirective('directive', 3, 21, 3, 32),
+      duplicateDirective('directive', 5, 25, 5, 36),
+      duplicateDirective('directive', 6, 32, 6, 43),
+      duplicateDirective('directive', 8, 23, 8, 34),
+      duplicateDirective('directive', 9, 30, 9, 41),
+      duplicateDirective('directive', 11, 31, 11, 42),
+      duplicateDirective('directive', 12, 38, 12, 49),
+      duplicateDirective('directive', 14, 23, 14, 34),
+      duplicateDirective('directive', 15, 30, 15, 41),
+      duplicateDirective('directive', 17, 23, 17, 34),
+      duplicateDirective('directive', 18, 30, 18, 41),
+    ]);
+  });
 });

src/validation/__tests__/harness.js

@@ -7,7 +7,7 @@
 
 import { expect } from 'chai';
 import { parse } from '../../language';
-import { validate } from '../validate';
+import { validate, validateSDL } from '../validate';
 import {
   GraphQLSchema,
   GraphQLObjectType,
@@ -448,3 +448,8 @@ export function expectPassesRuleWithSchema(schema, rule, queryString) {
 export function expectFailsRuleWithSchema(schema, rule, queryString, errors) {
   return expectInvalid(schema, rule, queryString, errors);
 }
+
+export function expectSDLErrorsFromRule(rule, sdlString, schema) {
+  const errors = validateSDL(parse(sdlString), schema, [rule]);
+  return expect(errors);
+}

src/validation/specifiedRules.js

@@ -127,4 +127,5 @@ import { LoneSchemaDefinition } from './rules/LoneSchemaDefinition';
 // @internal
 export const specifiedSDLRules: $ReadOnlyArray<SDLValidationRule> = [
   LoneSchemaDefinition,
+  UniqueDirectivesPerLocation,
 ];