Skip to content

Commit cdd0b55

Browse files
authored
Apply suggestions from code review
1 parent f2a6e9d commit cdd0b55

File tree

2 files changed

+6
-6
lines changed

2 files changed

+6
-6
lines changed

src/execution/__tests__/variables-test.ts

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -96,11 +96,11 @@ const TestNestedInputObject = new GraphQLInputObjectType({
9696

9797
const TestOneOfInputObject = new GraphQLInputObjectType({
9898
name: 'TestOneOfInputObject',
99+
isOneOf: true,
99100
fields: {
100101
a: { type: GraphQLString },
101102
b: { type: GraphQLInt },
102103
},
103-
isOneOf: true,
104104
});
105105

106106
const TestEnum = new GraphQLEnumType({
@@ -1268,7 +1268,7 @@ describe('Execute: Handles inputs', () => {
12681268
});
12691269
});
12701270

1271-
it('errors with variable with no value', () => {
1271+
it('errors with variable object with no fields', () => {
12721272
const result = executeQuery(
12731273
`
12741274
query ($input: TestOneOfInputObject) {
@@ -1289,7 +1289,7 @@ describe('Execute: Handles inputs', () => {
12891289
});
12901290
});
12911291

1292-
it('errors with variable with multiple values', () => {
1292+
it('errors with variable object with multiple fields', () => {
12931293
const result = executeQuery(
12941294
`
12951295
query ($input: TestOneOfInputObject) {
@@ -1310,7 +1310,7 @@ describe('Execute: Handles inputs', () => {
13101310
});
13111311
});
13121312

1313-
it('errors with variable with single null value', () => {
1313+
it('errors with variable object with single null field', () => {
13141314
const result = executeQuery(
13151315
`
13161316
query ($input: TestOneOfInputObject) {
@@ -1331,7 +1331,7 @@ describe('Execute: Handles inputs', () => {
13311331
});
13321332
});
13331333

1334-
it('errors with variable with multiple values, only one non-null', () => {
1334+
it('errors with variable object with multiple fields, only one non-null', () => {
13351335
const result = executeQuery(
13361336
`
13371337
query ($input: TestOneOfInputObject) {

src/utilities/coerceInputValue.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -135,7 +135,7 @@ function coerceInputValueImpl(
135135
}
136136

137137
/**
138-
* keys with the value "undefined" do not appear within the coerced input
138+
* Keys with the value "undefined" do not appear within the coerced input
139139
* object, but do appear within the original input object.
140140
*
141141
* Note: in graphql-js, supplying the value "undefined" for a variable

0 commit comments

Comments
 (0)