apply review feedback

Author: yaacovCR

src/execution/__tests__/subscribe-test.ts

@@ -458,6 +458,7 @@ describe('Subscription Initialization Phase', () => {
       'Must provide document.',
     );
 
+    // @ts-expect-error
     expect(() => createSourceEventStream(schema)).to.throw(
       'Must provide document.',
     );

src/execution/subscribe.ts

@@ -119,20 +119,26 @@ function mapSourceToResponse(
  * or otherwise separating these two steps. For more on this, see the
  * "Supporting Subscriptions at Scale" information in the GraphQL specification.
  */
+export function createSourceEventStream(
+  args: ExecutionArgs,
+): PromiseOrValue<AsyncIterable<unknown> | ExecutionResult>;
+/** @deprecated will be removed in next major version in favor of named arguments */
+export function createSourceEventStream(
+  schema: GraphQLSchema,
+  document: DocumentNode,
+  rootValue?: unknown,
+  contextValue?: unknown,
+  variableValues?: Maybe<{ readonly [variable: string]: unknown }>,
+  operationName?: Maybe<string>,
+  subscribeFieldResolver?: Maybe<GraphQLFieldResolver<any, any>>,
+): PromiseOrValue<AsyncIterable<unknown> | ExecutionResult>;
 export function createSourceEventStream(
   argsOrSchema: ExecutionArgs | GraphQLSchema,
-  /** Note: document argument is required if positional arguments are used */
-  /** @deprecated will be removed in next major version in favor of named arguments */
   document?: DocumentNode,
-  /** @deprecated will be removed in next major version in favor of named arguments */
   rootValue?: unknown,
-  /** @deprecated will be removed in next major version in favor of named arguments */
   contextValue?: unknown,
-  /** @deprecated will be removed in next major version in favor of named arguments */
   variableValues?: Maybe<{ readonly [variable: string]: unknown }>,
-  /** @deprecated will be removed in next major version in favor of named arguments */
   operationName?: Maybe<string>,
-  /** @deprecated will be removed in next major version in favor of named arguments */
   subscribeFieldResolver?: Maybe<GraphQLFieldResolver<any, any>>,
 ): PromiseOrValue<AsyncIterable<unknown> | ExecutionResult> {
   if (isSchema(argsOrSchema)) {