Skip to content

Commit ed321bb

Browse files
committed
polish(incremental): remove unnecessary check
completeDeferredFragment will always return undefined if the deferredFragmentRecord has already been removed from the graph
1 parent 75dca3d commit ed321bb

File tree

1 file changed

+2
-8
lines changed

1 file changed

+2
-8
lines changed

src/execution/IncrementalPublisher.ts

Lines changed: 2 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -261,19 +261,13 @@ class IncrementalPublisher {
261261

262262
for (const deferredFragmentRecord of deferredGroupedFieldSetResult
263263
.deferredGroupedFieldSetRecord.deferredFragmentRecords) {
264-
const id = deferredFragmentRecord.id;
265-
// TODO: add test case for this.
266-
// Presumably, this can occur if an error causes a fragment to be completed early,
267-
// while an asynchronous deferred grouped field set result is enqueued.
268-
/* c8 ignore next 3 */
269-
if (id === undefined) {
270-
continue;
271-
}
272264
const reconcilableResults =
273265
this._incrementalGraph.completeDeferredFragment(deferredFragmentRecord);
274266
if (reconcilableResults === undefined) {
275267
continue;
276268
}
269+
const id = deferredFragmentRecord.id;
270+
invariant(id !== undefined);
277271
const incremental = context.incremental;
278272
for (const reconcilableResult of reconcilableResults) {
279273
const { bestId, subPath } = this._getBestIdAndSubPath(

0 commit comments

Comments
 (0)