temp

Author: saihaj

.eslintrc.yml

@@ -450,7 +450,7 @@ overrides:
       '@typescript-eslint/ban-ts-comment': [error, { 'ts-expect-error': false }]
       '@typescript-eslint/ban-tslint-comment': error
       '@typescript-eslint/ban-types': error
-      '@typescript-eslint/class-literal-property-style': off # TODO enable after TS conversion
+      '@typescript-eslint/class-literal-property-style': error
       '@typescript-eslint/consistent-indexed-object-style': off # TODO enable after TS conversion
       '@typescript-eslint/consistent-type-assertions':
         [error, { assertionStyle: as, objectLiteralTypeAssertions: never }]
@@ -472,7 +472,7 @@ overrides:
       '@typescript-eslint/no-extraneous-class': off # TODO consider
       '@typescript-eslint/no-floating-promises': error
       '@typescript-eslint/no-for-in-array': error
-      '@typescript-eslint/no-implicit-any-catch': off # TODO: Enable after TS convertion
+      '@typescript-eslint/no-implicit-any-catch': error
       '@typescript-eslint/no-implied-eval': error
       '@typescript-eslint/no-inferrable-types':
         [error, { ignoreParameters: true, ignoreProperties: true }]
@@ -500,7 +500,7 @@ overrides:
       '@typescript-eslint/non-nullable-type-assertion-style': error
       '@typescript-eslint/prefer-as-const': off # TODO consider
       '@typescript-eslint/prefer-enum-initializers': off # TODO consider
-      '@typescript-eslint/prefer-for-of': off # TODO switch to error after TS migration
+      '@typescript-eslint/prefer-for-of': error
       '@typescript-eslint/prefer-function-type': error
       '@typescript-eslint/prefer-includes': off # TODO switch to error after IE11 drop
       '@typescript-eslint/prefer-literal-enum-member': error

src/__tests__/starWarsSchema.ts

@@ -128,7 +128,7 @@ const { nodeInterface, nodeField } = nodeDefinitions(
  *     name: String
  *   }
  */
-const shipType = new GraphQLObjectType({
+const shipType: GraphQLObjectType = new GraphQLObjectType({
   name: 'Ship',
   description: 'A ship in the Star Wars saga',
   interfaces: [nodeInterface],
@@ -171,7 +171,7 @@ const { connectionType: shipConnection } = connectionDefinitions({
  *     ships: ShipConnection
  *   }
  */
-const factionType = new GraphQLObjectType({
+const factionType: GraphQLObjectType = new GraphQLObjectType({
   name: 'Faction',
   description: 'A faction in the Star Wars saga',
   interfaces: [nodeInterface],

src/connection/connection.ts

@@ -90,7 +90,7 @@ interface GraphQLConnectionDefinitions {
 
 function resolveMaybeThunk<T>(thingOrThunk: Thunk<T>): T {
   return typeof thingOrThunk === 'function'
-    ? // $FlowFixMe[incompatible-use] - if it's a function, we assume a thunk without arguments
+    ? // @ts-expect-error - if it's a function, we assume a thunk without arguments
       thingOrThunk()
     : thingOrThunk;
 }
@@ -107,19 +107,21 @@ export function connectionDefinitions(
   const edgeType = new GraphQLObjectType({
     name: name + 'Edge',
     description: 'An edge in a connection.',
-    fields: () => ({
-      node: {
-        type: nodeType,
-        resolve: config.resolveNode,
-        description: 'The item at the end of the edge',
-      },
-      cursor: {
-        type: new GraphQLNonNull(GraphQLString),
-        resolve: config.resolveCursor,
-        description: 'A cursor for use in pagination',
-      },
-      ...resolveMaybeThunk(config.edgeFields ?? {}),
-    }),
+    fields(): GraphQLFieldConfigMap<unknown, unknown> {
+      return {
+        node: {
+          type: nodeType,
+          resolve: config.resolveNode,
+          description: 'The item at the end of the edge',
+        },
+        cursor: {
+          type: new GraphQLNonNull(GraphQLString),
+          resolve: config.resolveCursor,
+          description: 'A cursor for use in pagination',
+        },
+        ...resolveMaybeThunk(config.edgeFields ?? {}),
+      };
+    },
   });
 
   const connectionType = new GraphQLObjectType({

src/mutation/mutation.ts

@@ -17,7 +17,7 @@ type MutationFn = (object: any, ctx: any, info: GraphQLResolveInfo) => unknown;
 
 function resolveMaybeThunk<T>(thingOrThunk: Thunk<T>): T {
   return typeof thingOrThunk === 'function'
-    ? // $FlowFixMe[incompatible-use] - if it's a function, we assume a thunk without arguments
+    ? // @ts-expect-error - if it's a function, we assume a thunk without arguments
       thingOrThunk()
     : thingOrThunk;
 }
@@ -95,7 +95,7 @@ export function mutationWithClientMutationId(
 
       function injectClientMutationId(data: unknown) {
         if (typeof data === 'object' && data !== null) {
-          // $FlowFixMe[cannot-write] It's bad idea to mutate data but we need to pass clientMutationId somehow. Maybe in future we figure out better solution satisfying all our test cases.
+          // @ts-expect-error FIXME It's bad idea to mutate data but we need to pass clientMutationId somehow. Maybe in future we figure out better solution satisfying all our test cases.
           data.clientMutationId = clientMutationId;
         }
 

src/mutation/type.d.ts

@@ -0,0 +1 @@
+declare module 'graphql/jsutils/isPromise';

src/node/__tests__/global-test.ts

@@ -72,7 +72,7 @@ const { nodeField, nodeInterface } = nodeDefinitions(
   },
 );
 
-const userType = new GraphQLObjectType({
+const userType: GraphQLObjectType = new GraphQLObjectType({
   name: 'User',
   interfaces: [nodeInterface],
   fields: () => ({
@@ -83,7 +83,7 @@ const userType = new GraphQLObjectType({
   }),
 });
 
-const photoType = new GraphQLObjectType({
+const photoType: GraphQLObjectType = new GraphQLObjectType({
   name: 'Photo',
   interfaces: [nodeInterface],
   fields: () => ({
@@ -94,7 +94,7 @@ const photoType = new GraphQLObjectType({
   }),
 });
 
-const postType = new GraphQLObjectType({
+const postType: GraphQLObjectType = new GraphQLObjectType({
   name: 'Post',
   interfaces: [nodeInterface],
   fields: () => ({

src/node/__tests__/node-test.ts

@@ -57,7 +57,7 @@ const { nodeField, nodesField, nodeInterface } = nodeDefinitions(
   },
 );
 
-const userType = new GraphQLObjectType({
+const userType: GraphQLObjectType = new GraphQLObjectType({
   name: 'User',
   interfaces: [nodeInterface],
   fields: () => ({
@@ -70,7 +70,7 @@ const userType = new GraphQLObjectType({
   }),
 });
 
-const photoType = new GraphQLObjectType({
+const photoType: GraphQLObjectType = new GraphQLObjectType({
   name: 'Photo',
   interfaces: [nodeInterface],
   fields: () => ({

src/node/__tests__/nodeAsync-test.ts

@@ -28,7 +28,7 @@ const { nodeField, nodeInterface } = nodeDefinitions(
   () => userType,
 );
 
-const userType = new GraphQLObjectType({
+const userType: GraphQLObjectType = new GraphQLObjectType({
   name: 'User',
   interfaces: [nodeInterface],
   fields: () => ({

src/utils/base64.ts

@@ -100,7 +100,8 @@ function fromBase64Char(base64Char: string | undefined): number {
 function stringToUTF8Array(input: string): Array<number> {
   const result = [];
   for (const utfChar of input) {
-    const code = utfChar.codePointAt(0);
+    // eslint-disable-next-line @typescript-eslint/no-non-null-assertion
+    const code = utfChar.codePointAt(0)!;
     if (code < 0x80) {
       result.push(code);
     } else if (code < 0x800) {

tsconfig.json

@@ -4,10 +4,7 @@
     "module": "commonjs",
     "lib": ["es2019", "es2020.promise", "es2020.bigint", "es2020.string"],
     "target": "es2019",
-    "noImplicitAny": false,
-    "noImplicitThis": false,
-    "strictNullChecks": false,
-    "strictFunctionTypes": false,
+    "strict": true,
     "noEmit": true,
     "isolatedModules": true,
     "forceConsistentCasingInFileNames": true