Skip to content

Commit 0ce2f8e

Browse files
committed
rename ExecuteFieldSet to ExecuteGroupedFieldSet
this is unfortunately more cumbersome, but more accurate. The grouped field set contains a map of.... field lists (which are also sort of field sets), so this longer name helps considerably with ambiguity. It may be helpful to later rename CollectRootFields and CollectSubfields to something like BuildRootFieldPlan and BuildSubfieldPlan and the product as FieldPlan, and then the execution step as ExecuteFieldPlan, but that can be done later.
1 parent 5c13361 commit 0ce2f8e

File tree

1 file changed

+7
-6
lines changed

1 file changed

+7
-6
lines changed

spec/Section 6 -- Execution.md

Lines changed: 7 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -133,7 +133,7 @@ ExecuteQuery(query, schema, variableValues, initialValue):
133133
- Let {selectionSet} be the top level Selection Set in {query}.
134134
- Let {groupedFieldSet} be the result of {CollectRootFields(queryType,
135135
selectionSet, variableValues)}.
136-
- Let {data} be the result of running {ExecuteFieldSet(groupedFieldSet,
136+
- Let {data} be the result of running {ExecuteGroupedFieldSet(groupedFieldSet,
137137
queryType, initialValue, variableValues)} _normally_ (allowing
138138
parallelization).
139139
- Let {errors} be the list of all _field error_ raised while executing the
@@ -157,7 +157,7 @@ ExecuteMutation(mutation, schema, variableValues, initialValue):
157157
- Let {selectionSet} be the top level Selection Set in {mutation}.
158158
- Let {groupedFieldSet} be the result of {CollectRootFields(mutationType,
159159
selectionSet, variableValues)}.
160-
- Let {data} be the result of running {ExecuteFieldSet(groupedFieldSet,
160+
- Let {data} be the result of running {ExecuteGroupedFieldSet(groupedFieldSet,
161161
mutationType, initialValue, variableValues)} _serially_.
162162
- Let {errors} be the list of all _field error_ raised while executing the
163163
selection set.
@@ -307,7 +307,7 @@ ExecuteSubscriptionEvent(subscription, schema, variableValues, initialValue):
307307
- Let {selectionSet} be the top level Selection Set in {subscription}.
308308
- Let {groupedFieldSet} be the result of {CollectRootFields(subscriptionType,
309309
selectionSet, variableValues)}.
310-
- Let {data} be the result of running {ExecuteFieldSet(groupedFieldSet,
310+
- Let {data} be the result of running {ExecuteGroupedFieldSet(groupedFieldSet,
311311
subscriptionType, initialValue, variableValues)} _normally_ (allowing
312312
parallelization).
313313
- Let {errors} be the list of all _field error_ raised while executing the
@@ -328,7 +328,7 @@ Unsubscribe(responseStream):
328328

329329
- Cancel {responseStream}
330330

331-
## Executing Field Sets
331+
## Executing Grouped Field Sets
332332

333333
To execute a grouped field set, the object value being evaluated and the object
334334
type need to be known, as well as whether it must be executed serially, or may
@@ -337,7 +337,8 @@ be executed in parallel.
337337
Each represented field in the grouped field set produces an entry into a
338338
response map.
339339

340-
ExecuteFieldSet(groupedFieldSet, objectType, objectValue, variableValues):
340+
ExecuteGroupedFieldSet(groupedFieldSet, objectType, objectValue,
341+
variableValues):
341342

342343
- Initialize {resultMap} to an empty ordered map.
343344
- For each {groupedFieldSet} as {responseKey} and {fields}:
@@ -708,7 +709,7 @@ CompleteValue(fieldType, fields, result, variableValues):
708709
- Let {objectType} be {ResolveAbstractType(fieldType, result)}.
709710
- Let {groupedSubfieldSet} be the result of calling
710711
{CollectSubfields(objectType, fields, variableValues)}.
711-
- Return the result of evaluating {ExecuteFieldSet(groupedSubfieldSet,
712+
- Return the result of evaluating {ExecuteGroupedFieldSet(groupedSubfieldSet,
712713
objectType, result, variableValues)} _normally_ (allowing for
713714
parallelization).
714715

0 commit comments

Comments
 (0)