Skip to content

Commit b6f94d6

Browse files
committed
[Support] Make printAllJSONValues public, for custom output.
Summary: This changes the static method TimerGroup::printAllJSONValues from private to public, to match the static method TimerGroup::printAll. When trying to drive the reporting machinery by hand, the existing API is _almost_ flexible enough, but this entrypoint is required to intermix printing timers with other non-timer output. The underlying motive here is a Swift change to consolidate the collection of timers, LLVM statistics and other (non-assert-dependent) counters into JSON files, which requires a bit of manual intervention in LLVM's stat and timer output routines. See swiftlang/swift#8477 for details. Reviewers: MatzeB Reviewed By: MatzeB Subscribers: llvm-commits Differential Revision: https://reviews.llvm.org/D31566 git-svn-id: https://llvm.org/svn/llvm-project/llvm/trunk@299371 91177308-0d34-0410-b5e6-96231b3b80d8
1 parent 9cb6a3c commit b6f94d6

File tree

1 file changed

+3
-1
lines changed

1 file changed

+3
-1
lines changed

include/llvm/Support/Timer.h

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -217,6 +217,9 @@ class TimerGroup {
217217
/// This static method prints all timers and clears them all out.
218218
static void printAll(raw_ostream &OS);
219219

220+
/// Prints all timers as JSON key/value pairs, and clears them all out.
221+
static const char *printAllJSONValues(raw_ostream &OS, const char *delim);
222+
220223
/// Ensure global timer group lists are initialized. This function is mostly
221224
/// used by the Statistic code to influence the construction and destruction
222225
/// order of the global timer lists.
@@ -231,7 +234,6 @@ class TimerGroup {
231234
void printJSONValue(raw_ostream &OS, const PrintRecord &R,
232235
const char *suffix, double Value);
233236
const char *printJSONValues(raw_ostream &OS, const char *delim);
234-
static const char *printAllJSONValues(raw_ostream &OS, const char *delim);
235237
};
236238

237239
} // end namespace llvm

0 commit comments

Comments
 (0)