Don't generate properties marked with json ignore attribute #13
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
greymind
approved these changes
Jan 11, 2017
dborovic
reviewed
Jan 11, 2017
| @@ -334,7 +334,7 @@ private List<MemberWithCSharpType> GetMembers(TypeDefinition typeDefinition) | |||
| }); | |||
|
|
|||
| var properties = typeDefinition.Properties | |||
| .Where(p => p.GetMethod != null && p.GetMethod.IsPublic && !p.IsSpecialName) | |||
| .Where(p => p.GetMethod != null && p.GetMethod.IsPublic && !p.IsSpecialName && !Helpers.HasCustomAttribute(p, "JsonIgnoreAttribute")) | |||
There was a problem hiding this comment.
Might be better to have a config, something like:
"IgnorePropertiesWithAttributes" and then specify attributes - those properties with those attributes will be ignored?
Might be better than having a magic string
There was a problem hiding this comment.
I like the idea, but I am fine with this being here for now, since it is the most occuring case, and we can figure out a scheme for enhanced attribute support/handling as a separate issue?
greymind
deleted the
issue-11-dont-generate-properties-with-json-ignore-attribute
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #11.