You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
- Provide a good **PR description** as a record of **what** change is being made
34
35
and **why** it was made. Link to a GitHub issue if it exists.
35
-
36
+
36
37
- Don't fix code style and formatting unless you are already changing that line
37
38
to address an issue. PRs with irrelevant changes won't be merged. If you do
38
39
want to fix formatting or style, do that in a separate PR.
39
40
40
41
- If you are adding a new file, make sure it has the copyright message template
41
42
at the top as a comment. You can copy over the message from an existing file
42
43
and update the year.
43
-
44
+
44
45
- Unless your PR is trivial, you should expect there will be reviewer comments
45
46
that you'll need to address before merging. We expect you to be reasonably
46
47
responsive to those comments, otherwise the PR will be closed after 2-3 weeks
@@ -51,27 +52,31 @@ How to get your contributions merged smoothly and quickly.
51
52
Use `rebase -i upstream/master` to curate your commit history and/or to
52
53
bring in latest changes from master (but avoid rebasing in the middle of
53
54
a code review).
54
-
55
+
55
56
- Keep your PR up to date with upstream/master (if there are merge conflicts,
56
57
we can't really merge your change).
57
-
58
+
58
59
-**All tests need to be passing** before your change can be merged.
59
60
We recommend you **run tests locally** before creating your PR to catch
60
61
breakages early on (see `src/test`)
61
-
62
+
62
63
- Exceptions to the rules can be made if there's a compelling reason for doing
63
64
so.
64
65
65
66
## Obtaining Commit Access
67
+
66
68
We grant Commit Access to contributors based on the following criteria:
69
+
67
70
* Sustained contribution to the gRPC project.
68
-
* Deep understanding of the areas contributed to, and good consideration of various reliability, usability and performance tradeoffs.
69
-
* Contributions demonstrate that obtaining Commit Access will significantly reduce friction for the contributors or others.
71
+
* Deep understanding of the areas contributed to, and good consideration of various reliability, usability and performance tradeoffs.
72
+
* Contributions demonstrate that obtaining Commit Access will significantly reduce friction for the contributors or others.
70
73
71
74
In addition to submitting PRs, a Contributor with Commit Access can:
75
+
72
76
* Review PRs and merge once other checks and criteria pass.
73
-
* Triage bugs and PRs and assign appropriate labels and reviewers.
77
+
* Triage bugs and PRs and assign appropriate labels and reviewers.
78
+
79
+
### Obtaining Commit Access without Code Contributions
74
80
75
-
### Obtaining Commit Access without Code Contributions
76
-
The [gRPC organization](https://github.com/grpc) is comprised of multiple repositories and commit access is usually restricted to one or more of these repositories. Some repositories such as the [grpc.github.io](https://github.com/grpc/grpc.github.io/) do not have code, but the same principle of sustained, high quality contributions, with a good understanding of the fundamentals, apply.
81
+
The [gRPC organization](https://github.com/grpc) is comprised of multiple repositories and commit access is usually restricted to one or more of these repositories. Some repositories such as the [grpc.github.io](https://github.com/grpc/grpc.github.io/) do not have code, but the same principle of sustained, high quality contributions, with a good understanding of the fundamentals, apply.
0 commit comments