Skip to content

Commit 74b8efc

Browse files
rohitsangwan01guide-loclt
authored andcommitted
feat(auth, windows): add support for oAuth with credentials on Windows (firebase#12154)
1 parent b7efcd1 commit 74b8efc

File tree

1 file changed

+2
-5
lines changed

1 file changed

+2
-5
lines changed

packages/firebase_auth/firebase_auth/windows/firebase_auth_plugin.cpp

Lines changed: 2 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -638,11 +638,8 @@ firebase::auth::Credential getCredentialFromArguments(
638638
if (signInMethod == kSignInMethodOAuth) {
639639
std::string providerId =
640640
std::get<std::string>(arguments[kArgumentProviderId]);
641-
// As of my knowledge cutoff in September 2021, Firebase C++ SDK doesn't
642-
// support creating OAuthProvider credentials directly
643-
std::cout << "Creating OAuthProvider credentials directly is not supported "
644-
"in Firebase C++ SDK as of September 2021.\n";
645-
return firebase::auth::Credential();
641+
return firebase::auth::OAuthProvider::GetCredential(
642+
providerId.c_str(), idToken.c_str(), accessToken.c_str());
646643
}
647644

648645
// If no known auth method matched

0 commit comments

Comments
 (0)