Skip to content

Commit 3351e3c

Browse files
committed
TEST/MINOR: e2e: swap kill -SIGUSR with kill -s 12 invocations
1 parent 38e313f commit 3351e3c

File tree

8 files changed

+13
-13
lines changed

8 files changed

+13
-13
lines changed

.gitlab-ci.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@ stages:
44
- e2e
55
variables:
66
DOCKER_HOST: tcp://docker:2375
7-
DOCKER_BASE_IMAGE: $CI_REGISTRY_GO/haproxy-alpine
7+
DOCKER_BASE_IMAGE: haproxytech/haproxy-debian
88
BATS_VERSION: v1.4.1
99
GO_VERSION: '1.21'
1010

e2e/fixtures/dataplaneapi-master-socket.yaml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -15,8 +15,8 @@ haproxy:
1515
master_runtime: /var/lib/haproxy/master
1616
master_worker_mode: true
1717
reload:
18-
reload_cmd: kill -SIGUSR2 1
19-
restart_cmd: kill -SIGUSR2 1
18+
reload_cmd: kill -s 12 1
19+
restart_cmd: kill -s 12 1
2020
log:
2121
log_to: file
2222
log_file: /var/log/dataplaneapi.log

e2e/fixtures/dataplaneapi.yaml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -13,8 +13,8 @@ haproxy:
1313
config_file: /etc/haproxy/haproxy.cfg
1414
haproxy_bin: /usr/local/sbin/haproxy
1515
reload:
16-
reload_cmd: kill -SIGUSR2 1
17-
restart_cmd: kill -SIGUSR2 1
16+
reload_cmd: kill -s 12 1
17+
restart_cmd: kill -s 12 1
1818
log:
1919
log_to: file
2020
log_file: /var/log/dataplaneapi.log

e2e/libs/haproxy_config_setup.bash

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -72,7 +72,7 @@ setup() {
7272
assert_success
7373
fi
7474

75-
run dpa_docker_exec 'kill -SIGUSR2 1'
75+
run dpa_docker_exec 'kill -s 12 1'
7676
assert_success
7777

7878
run dpa_docker_exec 'pkill -9 dataplaneapi'
@@ -111,7 +111,7 @@ teardown() {
111111
run docker cp "${E2E_DIR}/fixtures/dataplaneapi.yaml" "${DOCKER_CONTAINER_NAME}:/etc/haproxy/dataplaneapi.yaml"
112112
assert_success
113113

114-
run dpa_docker_exec 'kill -SIGUSR2 1'
114+
run dpa_docker_exec 'kill -s 12 1'
115115
assert_success
116116

117117
run dpa_docker_exec 'pkill -9 dataplaneapi'

e2e/run.bash

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,7 @@ set -eo pipefail
1919
export BASE_PATH="/v2"
2020

2121
HAPROXY_VERSION=${HAPROXY_VERSION:-2.9}
22-
DOCKER_BASE_IMAGE="${DOCKER_BASE_IMAGE:-haproxytech/haproxy-alpine}:${HAPROXY_VERSION}"
22+
DOCKER_BASE_IMAGE="${DOCKER_BASE_IMAGE:-haproxytech/haproxy-debian}:${HAPROXY_VERSION}"
2323
DOCKER_CONTAINER_NAME="dataplaneapi-e2e"
2424
export DOCKER_CONTAINER_NAME
2525

e2e/tests/set_uid/dataplaneapi.yaml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -15,5 +15,5 @@ haproxy:
1515
config_file: /home/testuiduser/haproxy.cfg
1616
haproxy_bin: /usr/local/sbin/haproxy
1717
reload:
18-
reload_cmd: kill -SIGUSR2 1
19-
restart_cmd: kill -SIGUSR2 1
18+
reload_cmd: kill -s 12 1
19+
restart_cmd: kill -s 12 1

e2e/tests/set_uid/test.bats

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,7 @@
1818
load '../../libs/dataplaneapi'
1919

2020
setup() {
21-
run dpa_docker_exec 'kill -SIGUSR2 1'
21+
run dpa_docker_exec 'kill -s 12 1'
2222
assert_success
2323

2424
run dpa_docker_exec 'pkill -9 dataplaneapi'
@@ -48,7 +48,7 @@ teardown() {
4848
run docker cp "${E2E_DIR}/fixtures/dataplaneapi.yaml" "${DOCKER_CONTAINER_NAME}:/usr/local/bin/dataplaneapi.yaml"
4949
assert_success
5050

51-
run dpa_docker_exec 'kill -SIGUSR2 1'
51+
run dpa_docker_exec 'kill -s 12 1'
5252
assert_success
5353

5454
run dpa_docker_exec 'pkill -9 dataplaneapi'

e2e/tests/storage_maps/test.bats

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -41,7 +41,7 @@ load 'utils/_helpers'
4141

4242
# sometimes we can't establish a connection to the haproxy stat socket
4343
# forcing haproxy to restart seems to fix that
44-
assert dpa_docker_exec 'kill -SIGUSR2 1'
44+
assert dpa_docker_exec 'kill -s 12 1'
4545
sleep 1
4646

4747
resource_get "$_STORAGE_MAPS_BASE_PATH/"

0 commit comments

Comments
 (0)