MINOR: add deprecation warning log to Httpclose HTTPKeepAlive and HTTPServerClose

Author: hdurand0710

embedded_spec.go

@@ -22,7 +22,7 @@ require (
 	github.com/go-openapi/validate v0.22.1
 	github.com/google/renameio v1.0.1
 	github.com/google/uuid v1.3.0
-	github.com/haproxytech/client-native/v5 v5.0.1-0.20230710054839-8879b6b71da0
+	github.com/haproxytech/client-native/v5 v5.0.1-0.20230801141958-2081a288d108
 	github.com/haproxytech/config-parser/v5 v5.0.1-0.20230621085204-83b68fc565ef
 	github.com/jessevdk/go-flags v1.5.0
 	github.com/json-iterator/go v1.1.12
@@ -75,6 +75,6 @@ require (
 	github.com/tklauser/numcpus v0.6.1 // indirect
 	github.com/yusufpapurcu/wmi v1.2.3 // indirect
 	go.mongodb.org/mongo-driver v1.12.0 // indirect
-	golang.org/x/exp v0.0.0-20230711023510-fffb14384f22 // indirect
+	golang.org/x/exp v0.0.0-20230725093048-515e97ebf090 // indirect
 	gopkg.in/yaml.v3 v3.0.1 // indirect
 )

go.mod

@@ -129,8 +129,8 @@ github.com/google/uuid v1.1.1/go.mod h1:TIyPZe4MgqvfeYDBFedMoGGpEw/LqOeaOT+nhxU+
 github.com/google/uuid v1.3.0 h1:t6JiXgmwXMjEs8VusXIJk2BXHsn+wx8BZdTaoZ5fu7I=
 github.com/google/uuid v1.3.0/go.mod h1:TIyPZe4MgqvfeYDBFedMoGGpEw/LqOeaOT+nhxU+yHo=
 github.com/gorilla/mux v1.8.0/go.mod h1:DVbg23sWSpFRCP0SfiEN6jmj59UnW/n46BH5rLB71So=
-github.com/haproxytech/client-native/v5 v5.0.1-0.20230710054839-8879b6b71da0 h1:V6y1VsT+IRoKi5FDmkb3qVqXzOnBr99gwEXVvySgQPw=
-github.com/haproxytech/client-native/v5 v5.0.1-0.20230710054839-8879b6b71da0/go.mod h1:du1wLSojM66Iv+GhkN6a84wcIfe31nwykRtiZjXJ0zo=
+github.com/haproxytech/client-native/v5 v5.0.1-0.20230801141958-2081a288d108 h1:sy3iSLEcXmfFdH4fs82uFmtXDbK0zQCrMTS68pXr900=
+github.com/haproxytech/client-native/v5 v5.0.1-0.20230801141958-2081a288d108/go.mod h1:IWu0kV+P/MU0eIfUPLdCaHWGOBhPCeKrdrEyPOAKBXo=
 github.com/haproxytech/config-parser/v5 v5.0.1-0.20230621085204-83b68fc565ef h1:IXxc+Mxwj1FMrnvqN/FmP+x5Uc7AaWX6Nwirft/qfcI=
 github.com/haproxytech/config-parser/v5 v5.0.1-0.20230621085204-83b68fc565ef/go.mod h1:7JxHGhCD6WRRc+++7QRBMjoUZMYEP+JRQmp/nBGI9zo=
 github.com/haproxytech/go-logger v1.1.0 h1:HgGtYaI1ApkvbQdsm7f9AzQQoxTB7w37criTflh7IQE=
@@ -266,8 +266,8 @@ golang.org/x/crypto v0.0.0-20190422162423-af44ce270edf/go.mod h1:WFFai1msRO1wXaE
 golang.org/x/crypto v0.0.0-20200302210943-78000ba7a073/go.mod h1:LzIPMQfyMNhhGPhUkYOs5KpL4U8rLKemX1yGLhDgUto=
 golang.org/x/crypto v0.0.0-20210921155107-089bfa567519/go.mod h1:GvvjBRRGRdwPK5ydBHafDWAxML/pGHZbMvKqRZ5+Abc=
 golang.org/x/crypto v0.0.0-20220622213112-05595931fe9d/go.mod h1:IxCIyHEi3zRg3s0A5j5BB6A9Jmi73HwBIUl50j+osU4=
-golang.org/x/exp v0.0.0-20230711023510-fffb14384f22 h1:FqrVOBQxQ8r/UwwXibI0KMolVhvFiGobSfdE33deHJM=
-golang.org/x/exp v0.0.0-20230711023510-fffb14384f22/go.mod h1:FXUEEKJgO7OQYeo8N01OfiKP8RXMtf6e8aTskBGqWdc=
+golang.org/x/exp v0.0.0-20230725093048-515e97ebf090 h1:Di6/M8l0O2lCLc6VVRWhgCiApHV8MnQurBnFSHsQtNY=
+golang.org/x/exp v0.0.0-20230725093048-515e97ebf090/go.mod h1:FXUEEKJgO7OQYeo8N01OfiKP8RXMtf6e8aTskBGqWdc=
 golang.org/x/mod v0.6.0-dev.0.20220419223038-86c51ed26bb4/go.mod h1:jJ57K6gSWd91VN4djpZkiMVwK6gcyfeH4XE8wZrZaV4=
 golang.org/x/net v0.0.0-20190311183353-d8887717615a/go.mod h1:t9HGtf8HONx5eT2rtn7q6eTqICYqUVnKs3thJo3Qplg=
 golang.org/x/net v0.0.0-20190404232315-eb5bcb51f2a3/go.mod h1:t9HGtf8HONx5eT2rtn7q6eTqICYqUVnKs3thJo3Qplg=

go.sum

@@ -16,6 +16,8 @@
 package handlers
 
 import (
+	"github.com/haproxytech/dataplaneapi/log"
+
 	"github.com/go-openapi/runtime/middleware"
 	client_native "github.com/haproxytech/client-native/v5"
 	"github.com/haproxytech/client-native/v5/models"
@@ -53,6 +55,18 @@ type ReplaceBackendHandlerImpl struct {
 	ReloadAgent haproxy.IReloadAgent
 }
 
+func logDeprecatedFieldsWarning(b *models.Backend) {
+	if b.Httpclose != "" {
+		log.Warningf("Field Httpclose is deprecated. Use HTTPConnectionMode.")
+	}
+	if b.HTTPKeepAlive != "" {
+		log.Warningf("Field HTTPKeepAlive is deprecated. Use HTTPConnectionMode.")
+	}
+	if b.HTTPServerClose != "" {
+		log.Warningf("Field HTTPServerClose is deprecated. Use HTTPConnectionMode.")
+	}
+}
+
 // Handle executing the request and returning a response
 func (h *CreateBackendHandlerImpl) Handle(params backend.CreateBackendParams, principal interface{}) middleware.Responder {
 	t := ""
@@ -74,6 +88,8 @@ func (h *CreateBackendHandlerImpl) Handle(params backend.CreateBackendParams, pr
 		return backend.NewCreateBackendDefault(int(*e.Code)).WithPayload(e)
 	}
 
+	logDeprecatedFieldsWarning(params.Data)
+
 	configuration, err := h.Client.Configuration()
 	if err != nil {
 		e := misc.HandleError(err)
@@ -201,6 +217,8 @@ func (h *ReplaceBackendHandlerImpl) Handle(params backend.ReplaceBackendParams,
 		v = *params.Version
 	}
 
+	logDeprecatedFieldsWarning(params.Data)
+
 	if t != "" && *params.ForceReload {
 		msg := "Both force_reload and transaction specified, specify only one"
 		c := misc.ErrHTTPBadRequest