BUG/MINOR: consul: fix health_check_policy validation on update

rmaticevic · rmaticevic · commit 7b0b08e2d2ec · 2024-12-02T15:10:15.000+01:00
diff --git a/handlers/consul.go b/handlers/consul.go
@@ -139,7 +139,7 @@ func (c *ReplaceConsulHandlerImpl) Handle(params service_discovery.ReplaceConsul
 		e := misc.HandleError(err)
 		return service_discovery.NewReplaceConsulDefault(int(*e.Code)).WithPayload(e)
 	}
-	if *params.Data.HealthCheckPolicy == models.ConsulHealthCheckPolicyMin && params.Data.HealthCheckPolicyMin <= 0 {
+	if params.Data.HealthCheckPolicy != nil && *params.Data.HealthCheckPolicy == models.ConsulHealthCheckPolicyMin && params.Data.HealthCheckPolicyMin <= 0 {
 		e := &models.Error{
 			Message: misc.StringP("health_check_policy_min is required for 'min' health_check_policy"),
 			Code:    misc.Int64P(int(misc.ErrHTTPBadRequest)),

Original file line number	Diff line number	Diff line change
`@@ -139,7 +139,7 @@ func (c *ReplaceConsulHandlerImpl) Handle(params service_discovery.ReplaceConsul`
`139`	`139`	`e := misc.HandleError(err)`
`140`	`140`	`return service_discovery.NewReplaceConsulDefault(int(*e.Code)).WithPayload(e)`
`141`	`141`	`}`
`142`		`- if *params.Data.HealthCheckPolicy == models.ConsulHealthCheckPolicyMin && params.Data.HealthCheckPolicyMin <= 0 {`
	`142`	`+ if params.Data.HealthCheckPolicy != nil && *params.Data.HealthCheckPolicy == models.ConsulHealthCheckPolicyMin && params.Data.HealthCheckPolicyMin <= 0 {`
`143`	`143`	`e := &models.Error{`
`144`	`144`	`Message: misc.StringP("health_check_policy_min is required for 'min' health_check_policy"),`
`145`	`145`	`Code: misc.Int64P(int(misc.ErrHTTPBadRequest)),`