BUILD/MEDIUM: update linters, use local version

Author: oktalz

.github/workflows/lint.yml

@@ -5,12 +5,23 @@ on:
       - master
 jobs:
   golangci-lint:
-    name: runner / golangci-lint
+    name: golangci-lint
     runs-on: ubuntu-latest
     steps:
       - name: Check out code into the Go module directory
-        uses: actions/checkout@v1
-      - name: golangci-lint
-        uses: reviewdog/action-golangci-lint@v1
+        uses: actions/checkout@v2
+      - name: Set up Go
+        uses: actions/setup-go@v2
         with:
-          github_token: ${{ secrets.github_token }}
+          go-version: 1.19
+      - uses: actions/cache@v2
+        with:
+          path: |
+            ~/.cache/go-build
+            ~/go/pkg/mod
+          key: ${{ runner.os }}-go-${{ hashFiles('**/go.sum') }}
+          restore-keys: |
+            ${{ runner.os }}-go-
+      - name: Lint
+        run: |
+          make lint

.gitignore

@@ -3,3 +3,4 @@ vendor/
 cmd/dataplaneapi/*
 .vscode/
 .test/
+bin/golangci-lint

.gitlab-ci.yml

@@ -34,12 +34,12 @@ golangci-lint:
     paths:
       - build
   image:
-    name: $CI_REGISTRY_GO/lint:1.50.0
+    name: $CI_REGISTRY_GO/golang:1.19
     entrypoint: [""]
   tags:
     - go
   script:
-    - golangci-lint run --timeout 5m --color always --max-issues-per-linter 0 --max-same-issues 0
+    - make lint
   rules:
     - if: $CI_PIPELINE_SOURCE == 'merge_request_event'
     - if: $CI_PIPELINE_SOURCE == 'push'

.golangci.yml

@@ -4,27 +4,58 @@ linters-settings:
   golint:
     min-confidence: 0
   gocyclo:
-    min-complexity: 25
+    min-complexity: 42
   maligned:
     suggest-new: true
   dupl:
     threshold: 200
   goconst:
     min-len: 2
     min-occurrences: 2
-
+  revive:
+    rules:
+    - name: var-naming
+      severity: warning
+      disabled: true
 linters:
-  enable:
-    - golint
-    - gocritic
-    - stylecheck
-    - goimports
-    - gosec
-    - unconvert
+  enable-all: true
   disable:
-    - maligned
-    - prealloc
+    - dupl
+    - exhaustive
+    - exhaustivestruct
+    - funlen
+    - gci
     - gochecknoglobals
+    - gocognit
+    - goconst
+    - gocyclo
+    - godot
+    - goerr113
+    - gomnd
+    - lll
+    - nestif
+    - nlreturn
+    - wrapcheck
+    - wsl
+    - nakedret
+    - paralleltest
+    - testpackage
+    - varnamelen
+    - nosnakecase
+    - exhaustruct
+    - nonamedreturns
+    - forcetypeassert
+    - golint #deprecated
+    - varcheck #deprecated
+    - ifshort #deprecated
+    - structcheck #deprecated
+    - maligned #deprecated
+    - scopelint #deprecated
+    - interfacer #deprecated
+    - deadcode #deprecated
+    - rowserrcheck #rowserrcheck is disabled because of generics
+    - sqlclosecheck #rowserrcheck is disabled because of generics
+    - wastedassign #rowserrcheck is disabled because of generics
 
 issues:
   exclude-rules:

Makefile

@@ -9,12 +9,18 @@ GIT_MODIFIED=${GIT_MODIFIED1}${GIT_MODIFIED2}
 SWAGGER_VERSION=${shell curl -s https://raw.githubusercontent.com/haproxytech/client-native/master/Makefile | grep SWAGGER_VERSION -m 1 | awk -F"=" '{print $$2}'}
 BUILD_DATE=$(shell date -u '+%Y-%m-%dT%H:%M:%SZ')
 CGO_ENABLED?=0
+GOLANGCI_LINT_VERSION=1.50.1
 
 all: update clean build
 
 update:
 	go mod tidy
 
+.PHONY: lint
+lint:
+	cd bin;GOLANGCI_LINT_VERSION=${GOLANGCI_LINT_VERSION} sh lint-check.sh
+	bin/golangci-lint run --timeout 5m --color always --max-issues-per-linter 0 --max-same-issues 0
+
 clean:
 	rm -rf ${DATAPLANEAPI_PATH}/build
 

bin/lint-check.sh

@@ -0,0 +1,7 @@
+#!/bin/sh
+V=$(./golangci-lint --version)
+
+case "$V" in
+  *$GOLANGCI_LINT_VERSION*) echo "$V" ;;
+  *)          curl -sSfL https://raw.githubusercontent.com/golangci/golangci-lint/master/install.sh | sh -s -- -b $(pwd) "v$GOLANGCI_LINT_VERSION" ;;
+esac