Skip to content

Commit 000976f

Browse files
tun0oktalz
authored andcommitted
DOC/MINOR: Upgrade Ingress API version in Canary example
Signed-off-by: Ruben Laban <[email protected]>
1 parent a923fce commit 000976f

File tree

1 file changed

+12
-6
lines changed

1 file changed

+12
-6
lines changed

documentation/canary-deployment.md

Lines changed: 12 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -97,7 +97,7 @@ spec:
9797
9898
```yaml
9999
kind: Ingress
100-
apiVersion: networking.k8s.io/v1beta1
100+
apiVersion: networking.k8s.io/v1
101101
metadata:
102102
name: echo
103103
spec:
@@ -106,12 +106,18 @@ spec:
106106
http:
107107
paths:
108108
- path: /
109+
pathType: ImplementationSpecific
109110
backend:
110-
serviceName: echo-prod
111-
servicePort: http
112-
- backend:
113-
serviceName: echo-staging
114-
servicePort: http
111+
service:
112+
name: echo-prod
113+
port:
114+
name: http
115+
- pathType: ImplementationSpecific
116+
backend:
117+
service:
118+
name: echo-staging
119+
port:
120+
name: http
115121
```
116122
117123
We can have ingress rules for staging and production in the same ingress resource but they **should not** share the same path otherwise the latter will overwrite the former. To avoid any confusion we can have rules in different ingress resources.

0 commit comments

Comments
 (0)