CLEANUP/MINOR: remove server state save

this is not needed since we write data to haproxy.cfg file that is read during
reload

Author: oktalz

pkg/haproxy/env/defaults.go

@@ -12,8 +12,6 @@ func SetGlobal(global *models.Global, logTargets *models.LogTargets, env Env) {
 	global.MasterWorker = true
 	global.Pidfile = env.PIDFile
 	global.Localpeer = "local"
-	global.ServerStateBase = env.StateDir
-	global.ServerStateFile = "global"
 	runtimeAPIs := []*models.RuntimeAPI{}
 	if env.RuntimeSocket != "" {
 		runtimeAPIs = append(runtimeAPIs, &models.RuntimeAPI{
@@ -73,7 +71,6 @@ func SetGlobal(global *models.Global, logTargets *models.LogTargets, env Env) {
 func SetDefaults(defaults *models.Defaults) {
 	// Enforced values
 	// Logging is enforced in DefaultsPushConfiguration method
-	defaults.LoadServerStateFromFile = "global"
 
 	// Default values
 	enabled := "enabled"

pkg/haproxy/process/direct-control.go

@@ -54,14 +54,12 @@ func (d *directControl) Service(action string) (err error) {
 		_, err = process.Wait()
 		return err
 	case "reload":
-		logger.Error(saveServerState(d.Env.StateDir, d.API))
 		if processErr != nil {
 			logger.Errorf("haproxy is not running, trying to start it")
 			return d.Service("start")
 		}
 		return process.Signal(syscall.SIGUSR2)
 	case "restart":
-		logger.Error(saveServerState(d.Env.StateDir, d.API))
 		if processErr != nil {
 			logger.Errorf("haproxy is not running, trying to start it")
 			return d.Service("start")

pkg/haproxy/process/interface.go

@@ -3,11 +3,9 @@ package process
 import (
 	"bufio"
 	"os"
-	"path/filepath"
 	"strconv"
 	"syscall"
 
-	"github.com/haproxytech/client-native/v3/runtime"
 	"github.com/haproxytech/kubernetes-ingress/pkg/haproxy/api"
 	"github.com/haproxytech/kubernetes-ingress/pkg/haproxy/env"
 	"github.com/haproxytech/kubernetes-ingress/pkg/utils"
@@ -62,30 +60,3 @@ func haproxyProcess(pidFile string) (*os.Process, error) {
 	err = process.Signal(syscall.Signal(0))
 	return process, err
 }
-
-// Saves HAProxy servers state so it is retrieved after reload.
-func saveServerState(stateDir string, api runtime.Raw) error {
-	result, err := api.ExecuteRaw("show servers state")
-	if err != nil {
-		return err
-	}
-	var f *os.File
-	if f, err = os.Create(filepath.Join(stateDir, "global")); err != nil {
-		logger.Error(err)
-		return err
-	}
-	defer f.Close()
-	if _, err = f.Write([]byte(result[0])); err != nil {
-		logger.Error(err)
-		return err
-	}
-	if err = f.Sync(); err != nil {
-		logger.Error(err)
-		return err
-	}
-	if err = f.Close(); err != nil {
-		logger.Error(err)
-		return err
-	}
-	return nil
-}

pkg/haproxy/process/s6-overlay.go

@@ -31,13 +31,11 @@ func (d *s6Control) Service(action string) error {
 		// no need to stop it (s6)
 		return nil
 	case "reload":
-		logger.Error(saveServerState(d.Env.StateDir, d.API))
 		cmd = exec.Command("s6-svc", "-2", "/var/run/s6/services/haproxy")
 		cmd.Stdout = os.Stdout
 		cmd.Stderr = os.Stderr
 		return cmd.Run()
 	case "restart":
-		logger.Error(saveServerState(d.Env.StateDir, d.API))
 		// -t terminates and s6 will start it again
 		cmd = exec.Command("s6-svc", "-t", "/var/run/s6/services/haproxy")
 		cmd.Stdout = os.Stdout