Skip to content

Commit 2c3eef9

Browse files
committed
BUG/MINOR: Don't override default-server params in ExternalName
services.
1 parent 6c62131 commit 2c3eef9

File tree

1 file changed

+5
-2
lines changed

1 file changed

+5
-2
lines changed

controller/service/service.go

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -150,6 +150,9 @@ func (s *Service) getBackendModel(store store.K8s) (backend *models.Backend, err
150150
backend = &models.Backend{DefaultServer: &models.DefaultServer{}}
151151
crInUse = false
152152
}
153+
if backend.DefaultServer == nil {
154+
backend.DefaultServer = &models.DefaultServer{}
155+
}
153156
// configure backend model
154157
if s.modeTCP {
155158
backend.Mode = "tcp"
@@ -159,8 +162,8 @@ func (s *Service) getBackendModel(store store.K8s) (backend *models.Backend, err
159162
if backend.Name, err = s.GetBackendName(); err != nil {
160163
return nil, err
161164
}
162-
if s.resource.DNS != "" {
163-
backend.DefaultServer = &models.DefaultServer{InitAddr: "last,libc,none"}
165+
if s.resource.DNS != "" && backend.DefaultServer.InitAddr == "" {
166+
backend.DefaultServer.InitAddr = "last,libc,none"
164167
}
165168
if !crInUse {
166169
for _, a := range annotations.Backend(backend, store, s.certs) {

0 commit comments

Comments
 (0)