Skip to content

Commit 31f8f68

Browse files
committed
MINOR: make scale-server-slots annotation available at all scopes
1 parent 756f534 commit 31f8f68

File tree

3 files changed

+7
-5
lines changed

3 files changed

+7
-5
lines changed

controller/service/endpoints.go

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -39,7 +39,7 @@ func (s *Service) HandleHAProxySrvs(client api.HAProxyClient, store store.K8s) (
3939
backend.Name = s.backend.Name // set backendName in store.PortEndpoints for runtime updates.
4040
// scale servers
4141
if s.resource.DNS == "" {
42-
srvsScaled = s.scaleHAProxySrvs(backend, store)
42+
srvsScaled = s.scaleHAProxySrvs(backend)
4343
}
4444
// update servers
4545
for _, srvSlot := range backend.HAProxySrvs {
@@ -85,7 +85,7 @@ func (s *Service) updateHAProxySrv(client api.HAProxyClient, srvSlot store.HAPro
8585
}
8686

8787
// scaleHAproxySrvs adds servers to match available addresses
88-
func (s *Service) scaleHAProxySrvs(backend *store.RuntimeBackend, k8sStore store.K8s) (reload bool) {
88+
func (s *Service) scaleHAProxySrvs(backend *store.RuntimeBackend) (reload bool) {
8989
var flag bool
9090
var disabled []*store.HAProxySrv
9191
var annVal int
@@ -95,7 +95,7 @@ func (s *Service) scaleHAProxySrvs(backend *store.RuntimeBackend, k8sStore store
9595
// "servers-increment", "server-slots" are legacy annotations
9696
srvSlots := 42
9797
for _, annotation := range []string{"servers-increment", "server-slots", "scale-server-slots"} {
98-
annVal, annErr = annotations.Int(annotation, k8sStore.ConfigMaps.Main.Annotations)
98+
annVal, annErr = annotations.Int(annotation, s.annotations...)
9999
if annErr != nil {
100100
logger.Errorf("Scale HAProxy servers: %s", annErr)
101101
} else if annVal != 0 {

documentation/README.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -68,7 +68,7 @@ This is autogenerated from [doc.yaml](doc.yaml). Description can be found in [ge
6868
| [server-proto](#server-proto) | ["h2"] | | |:large_blue_circle:|:large_blue_circle:|:large_blue_circle:|
6969
| [server-ssl](#server-ssl) | [bool](#bool) | "false" | |:large_blue_circle:|:large_blue_circle:|:large_blue_circle:|
7070
| [set-host](#set-host) | string | | |:large_blue_circle:|:large_blue_circle:|:white_circle:|
71-
| [scale-server-slots](#backend-scaling) | number | 42 | |:large_blue_circle:|:white_circle:|:white_circle:|
71+
| [scale-server-slots](#backend-scaling) | number | 42 | |:large_blue_circle:|:large_blue_circle:|:large_blue_circle:|
7272
| [ssl-certificate](#ssl-offloading) | string | | |:large_blue_circle:|:white_circle:|:white_circle:|
7373
| [ssl-passthrough](#https) | [bool](#bool) | "false" | |:large_blue_circle:|:large_blue_circle:|:large_blue_circle:|
7474
| [ssl-redirect](#https) | [bool](#bool) | "false" | https |:large_blue_circle:|:large_blue_circle:|:white_circle:|
@@ -469,7 +469,7 @@ check-interval: "1m"
469469

470470
Sets the number of server slots to provision in order for HAProxy to scale dynamically with no reload. If this number is greater than the available endpoints/addresses, the remaining slots will be disabled (put on stand-by) and ready to be used. If this number is lower, the remaining endpoints/addresses will be added after scaling the HAProxy backend with a reload.
471471

472-
Available on: `configmap`
472+
Available on: `configmap` `ingress` `service`
473473

474474
:information_source: Equivalent old annotations are `servers-increment` and `server-slots`
475475

documentation/doc.yaml

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1456,6 +1456,8 @@ annotations:
14561456
- Integer value indicating the number of backend servers to provision. Defaults to 42.
14571457
applies_to:
14581458
- configmap
1459+
- ingress
1460+
- service
14591461
version_min: "1.4"
14601462
example: ['scale-server-slots: "75"']
14611463
- title: ssl-certificate

0 commit comments

Comments
 (0)