Skip to content

Commit 3d42779

Browse files
committed
REORG/MINOR: Group informers per resource types
1 parent 74febae commit 3d42779

File tree

1 file changed

+11
-9
lines changed

1 file changed

+11
-9
lines changed

controller/monitor.go

Lines changed: 11 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -30,15 +30,15 @@ func (c *HAProxyController) monitorChanges() {
3030

3131
informersSynced := []cache.InformerSynced{}
3232
stop := make(chan struct{})
33-
crManager := NewCRManager(&c.Store, c.k8s.RestConfig, c.OSArgs.CacheResyncPeriod, c.eventChan, stop)
34-
c.crManager = crManager
3533
epMirror := c.endpointsMirroring()
34+
c.crManager = NewCRManager(&c.Store, c.k8s.RestConfig, c.OSArgs.CacheResyncPeriod, c.eventChan, stop)
3635

3736
c.k8s.EventPods(c.PodNamespace, c.PodPrefix, c.OSArgs.CacheResyncPeriod, c.eventChan)
3837

3938
for _, namespace := range c.getWhitelistedNamespaces() {
4039
factory := informers.NewSharedInformerFactoryWithOptions(c.k8s.API, c.OSArgs.CacheResyncPeriod, informers.WithNamespace(namespace))
4140

41+
// Core.V1 Resources
4242
svci := factory.Core().V1().Services().Informer()
4343
c.k8s.EventsServices(c.eventChan, c.ingressChan, stop, svci, c.PublishService)
4444

@@ -51,22 +51,21 @@ func (c *HAProxyController) monitorChanges() {
5151
ci := factory.Core().V1().ConfigMaps().Informer()
5252
c.k8s.EventsConfigfMaps(c.eventChan, stop, ci)
5353

54-
var ii, ici cache.SharedIndexInformer
55-
ii, ici = c.getIngressSharedInformers(factory)
54+
informersSynced = append(informersSynced, svci.HasSynced, nsi.HasSynced, si.HasSynced, ci.HasSynced)
5655

56+
// Ingress and IngressClass Resources
57+
ii, ici := c.getIngressSharedInformers(factory)
5758
if ii == nil {
58-
logger.Panic("ingress resources not supported in this cluster")
59+
logger.Panic("Ingress Resource not supported in this cluster")
5960
}
6061
c.k8s.EventsIngresses(c.eventChan, stop, ii)
61-
62-
informersSynced = []cache.InformerSynced{svci.HasSynced, nsi.HasSynced, ii.HasSynced, si.HasSynced, ci.HasSynced}
63-
informersSynced = append(informersSynced, crManager.RunInformers(namespace)...)
64-
62+
informersSynced = append(informersSynced, ii.HasSynced)
6563
if ici != nil {
6664
c.k8s.EventsIngressClass(c.eventChan, stop, ici)
6765
informersSynced = append(informersSynced, ici.HasSynced)
6866
}
6967

68+
// Endpoints and EndpointSlices Resources
7069
epsi := c.getEndpointSlicesSharedInformer(factory)
7170
if epsi != nil {
7271
c.k8s.EventsEndpointSlices(c.eventChan, stop, epsi)
@@ -77,6 +76,9 @@ func (c *HAProxyController) monitorChanges() {
7776
c.k8s.EventsEndpoints(c.eventChan, stop, epi)
7877
informersSynced = append(informersSynced, epi.HasSynced)
7978
}
79+
80+
// Custom Resources
81+
informersSynced = append(informersSynced, c.crManager.RunInformers(namespace)...)
8082
}
8183

8284
if !cache.WaitForCacheSync(stop, informersSynced...) {

0 commit comments

Comments
 (0)