Skip to content

Commit cb71dd2

Browse files
committed
BUG/MINOR: Fix skipped reloads when processing tcp services.
1 parent 3f81d72 commit cb71dd2

File tree

1 file changed

+5
-2
lines changed

1 file changed

+5
-2
lines changed

controller/handler/tcp-services.go

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -31,6 +31,7 @@ func (t TCPServices) Update(k store.K8s, cfg *config.ControllerCfg, api api.HAPr
3131
if k.ConfigMaps.TCPServices == nil {
3232
return false, nil
3333
}
34+
var r bool
3435
reload = t.clearFrontends(api, k)
3536
var p tcpSvcParser
3637
for port, tcpSvcAnn := range k.ConfigMaps.TCPServices.Annotations {
@@ -43,14 +44,16 @@ func (t TCPServices) Update(k store.K8s, cfg *config.ControllerCfg, api api.HAPr
4344
frontend, errGet := api.FrontendGet(frontendName)
4445
// Create Frontend
4546
if errGet != nil {
46-
frontend, reload, err = t.createTCPFrontend(api, frontendName, port, p.sslOffload)
47+
frontend, r, err = t.createTCPFrontend(api, frontendName, port, p.sslOffload)
48+
reload = reload || r
4749
if err != nil {
4850
logger.Error(err)
4951
continue
5052
}
5153
}
5254
// Update Frontend
53-
reload, err = t.updateTCPFrontend(k, cfg, api, frontend, p)
55+
r, err = t.updateTCPFrontend(k, cfg, api, frontend, p)
56+
reload = reload || r
5457
if err != nil {
5558
logger.Errorf("TCP frontend '%s': update failed: %s", frontendName, err)
5659
}

0 commit comments

Comments
 (0)