Fix eslint shareable config using rushstack/eslint-patch

eslint/eslint#3458

Author: Morten N.O. Henriksen

packages/create-react-app/yarn.lock.cached

@@ -7,6 +7,8 @@
 
 'use strict';
 
+require('./patch');
+
 // This file contains the minimum ESLint configuration required for Create
 // React App support, and is used as the `baseConfig` for `eslint-loader`
 // to ensure that user-provided configs don't need this boilerplate.

packages/eslint-config-react-app/base.js

@@ -7,6 +7,8 @@
 
 'use strict';
 
+require('./patch');
+
 // Inspired by https://github.com/airbnb/javascript but less opinionated.
 
 // We use eslint-loader so even warnings are very visible.

packages/eslint-config-react-app/index.js

@@ -7,6 +7,8 @@
 
 'use strict';
 
+require('./patch');
+
 // We use eslint-loader so even warnings are very visible.
 // This is why we prefer to use "WARNING" level for potential errors,
 // and we try not to use "ERROR" level at all.

packages/eslint-config-react-app/jest.js

@@ -14,17 +14,20 @@
   "files": [
     "base.js",
     "index.js",
-    "jest.js"
+    "jest.js",
+    "patch.js"
   ],
-  "devDependencies": {
-    "@babel/eslint-parser": "^7.14.7"
-  },
   "peerDependencies": {
+    "eslint": "^7.30.0"
+  },
+  "dependencies": {
+    "@babel/core": "7.14.2",
     "@babel/eslint-parser": "^7.14.7",
+    "@rushstack/eslint-patch": "^1.0.6",
     "@typescript-eslint/eslint-plugin": "^4.0.0",
     "@typescript-eslint/parser": "^4.0.0",
     "babel-preset-react-app": "^10.0.0",
-    "eslint": "^7.30.0",
+    "confusing-browser-globals": "^1.0.10",
     "eslint-plugin-flowtype": "^5.2.0",
     "eslint-plugin-import": "^2.22.0",
     "eslint-plugin-jest": "^24.0.0",
@@ -33,18 +36,7 @@
     "eslint-plugin-react-hooks": "^4.0.8",
     "eslint-plugin-testing-library": "^3.9.0"
   },
-  "peerDependenciesMeta": {
-    "eslint-plugin-jest": {
-      "optional": true
-    },
-    "eslint-plugin-testing-library": {
-      "optional": true
-    }
-  },
-  "dependencies": {
-    "confusing-browser-globals": "^1.0.10"
-  },
   "engines": {
-    "node": "^10.12.0 || >=12.0.0"
+    "node": ">=14.0.0"
   }
 }

packages/eslint-config-react-app/package.json

@@ -0,0 +1,11 @@
+/**
+ * Copyright (c) 2015-present, Facebook, Inc.
+ *
+ * This source code is licensed under the MIT license found in the
+ * LICENSE file in the root directory of this source tree.
+ */
+
+ 'use strict';
+
+ // Fix eslint shareable config (https://github.com/eslint/eslint/issues/3458)
+ require('@rushstack/eslint-patch/modern-module-resolution');

packages/eslint-config-react-app/patch.js

@@ -36,7 +36,6 @@
   "devDependencies": {
     "@babel/code-frame": "7.12.13",
     "@babel/core": "7.14.2",
-    "@babel/eslint-parser": "^7.14.7",
     "anser": "1.4.10",
     "babel-jest": "^26.6.0",
     "babel-loader": "8.2.2",
@@ -46,13 +45,6 @@
     "cross-env": "7.0.3",
     "eslint": "^7.30.0",
     "eslint-config-react-app": "^6.0.0",
-    "eslint-plugin-flowtype": "^5.2.0",
-    "eslint-plugin-import": "^2.22.1",
-    "eslint-plugin-jest": "^24.1.0",
-    "eslint-plugin-jsx-a11y": "^6.3.1",
-    "eslint-plugin-react": "^7.21.5",
-    "eslint-plugin-react-hooks": "^4.2.0",
-    "eslint-plugin-testing-library": "^3.9.2",
     "flow-bin": "^0.116.0",
     "html-entities": "1.3.1",
     "jest": "26.6.0",

packages/react-error-overlay/package.json

@@ -29,11 +29,8 @@
   "types": "./lib/react-app.d.ts",
   "dependencies": {
     "@babel/core": "7.14.2",
-    "@babel/eslint-parser": "^7.14.7",
     "@pmmmwh/react-refresh-webpack-plugin": "0.5.0-rc.0",
     "@svgr/webpack": "5.5.0",
-    "@typescript-eslint/eslint-plugin": "^4.5.0",
-    "@typescript-eslint/parser": "^4.5.0",
     "babel-jest": "^26.6.0",
     "babel-loader": "8.2.2",
     "babel-plugin-named-asset-import": "^0.3.7",
@@ -48,13 +45,6 @@
     "dotenv-expand": "5.1.0",
     "eslint": "^7.30.0",
     "eslint-config-react-app": "^6.0.0",
-    "eslint-plugin-flowtype": "^5.2.0",
-    "eslint-plugin-import": "^2.22.1",
-    "eslint-plugin-jest": "^24.1.0",
-    "eslint-plugin-jsx-a11y": "^6.3.1",
-    "eslint-plugin-react": "^7.21.5",
-    "eslint-plugin-react-hooks": "^4.2.0",
-    "eslint-plugin-testing-library": "^3.9.2",
     "eslint-webpack-plugin": "^2.5.4",
     "file-loader": "^6.2.0",
     "fs-extra": "^10.0.0",

packages/react-scripts/package.json

@@ -23,7 +23,6 @@ function verifyPackageTree() {
     // These are packages most likely to break in practice.
     // See https://github.com/facebook/create-react-app/issues/1795 for reasons why.
     // I have not included Babel here because plugins typically don't import Babel (so it's not affected).
-    '@babel/eslint-parser',
     'babel-jest',
     'babel-loader',
     'jest',