Set z-index of nav menus to avoid overlap with other content #99
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jhrcek
changed the title
|
Lovely! |
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the following issue with the nav menus illustrated by a screenshot:
To see the issue in the currently deployed version, go to e.g. https://haskell.foundation/donations/, open the "News and Info" menu and try to open the "Resources" or "FAQ" from that menu. Notice it's almost impossible, because the menu is closed if you happen to hover over the corner thingy that ovelaps with the menu.
The fix is to set the z-index of the menus to 10 (which I'm doing here by using the z-10 css class from tailwind).
After this PR the menu is rendered in front of other content and doesn't have the "undesired closing" issue
