Skip to content

Commit 42b6219

Browse files
Enable support for multi auth for p2sVpnGateway (Azure#13749)
* enable multi Auth for p2sVpnGateway * allow multi auth for update-vpnServerConfig * fix update * Update ChangeLog.md Co-authored-by: Yunchi Wang <[email protected]>
1 parent de80a83 commit 42b6219

File tree

4 files changed

+62
-86
lines changed

4 files changed

+62
-86
lines changed

src/Network/Network/ChangeLog.md

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -21,6 +21,8 @@
2121
## Upcoming Release
2222
* Bugfix in Remove peering and connection commandlet for ExpressrouteCircuit scenario
2323
- Remove-AzExpressRouteCircuitPeeringConfig and Remove-AzExpressRouteCircuitConnectionConfig
24+
* Added multiple Authentication support for p2sVpnGateway
25+
- Updated `New-AzVpnServerConfiguration` and `Update-AzVpnServerConfiguration` to allow multiple authentication parameters to be set.
2426
## Version 4.3.0
2527
* Updated below cmdlet
2628
- `New-AzLoadBalancerFrontendIpConfigCommand`, `Set-AzLoadBalancerFrontendIpConfigCommand`, `Add-AzLoadBalancerFrontendIpConfigCommand`:

src/Network/Network/Cortex/VpnServerConfiguration/NewAzureRmVpnServerConfigurationCommand.cs

Lines changed: 0 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -31,7 +31,6 @@ namespace Microsoft.Azure.Commands.Network
3131

3232
[Cmdlet(VerbsCommon.New,
3333
ResourceManager.Common.AzureRMConstants.AzureRMPrefix + "VpnServerConfiguration",
34-
DefaultParameterSetName = CortexParameterSetNames.ByVpnServerConfigurationName + CortexParameterSetNames.ByCertificateAuthentication,
3534
SupportsShouldProcess = true),
3635
OutputType(typeof(PSVpnServerConfiguration))]
3736
public class NewAzureRmVpnServerConfigurationCommand : VpnServerConfigurationBaseCmdlet
@@ -76,64 +75,54 @@ public class NewAzureRmVpnServerConfigurationCommand : VpnServerConfigurationBas
7675

7776
[Parameter(
7877
Mandatory = false,
79-
ParameterSetName = CortexParameterSetNames.ByVpnServerConfigurationName + CortexParameterSetNames.ByCertificateAuthentication,
8078
HelpMessage = "A list of VpnClientRootCertificates to be added files' paths")]
8179
public string[] VpnClientRootCertificateFilesList { get; set; }
8280

8381
[Parameter(
8482
Mandatory = false,
85-
ParameterSetName = CortexParameterSetNames.ByVpnServerConfigurationName + CortexParameterSetNames.ByCertificateAuthentication,
8683
HelpMessage = "A list of VpnClientCertificates to be revoked files' paths")]
8784
public string[] VpnClientRevokedCertificateFilesList { get; set; }
8885

8986
[Parameter(
9087
Mandatory = false,
91-
ParameterSetName = CortexParameterSetNames.ByVpnServerConfigurationName + CortexParameterSetNames.ByRadiusAuthentication,
9288
HelpMessage = "P2S External Radius server address.")]
9389
public string RadiusServerAddress { get; set; }
9490

9591
[Parameter(
9692
Mandatory = false,
97-
ParameterSetName = CortexParameterSetNames.ByVpnServerConfigurationName + CortexParameterSetNames.ByRadiusAuthentication,
9893
HelpMessage = "P2S External Radius server secret.")]
9994
public SecureString RadiusServerSecret { get; set; }
10095

10196
[Parameter(
10297
Mandatory = false,
103-
ParameterSetName = CortexParameterSetNames.ByVpnServerConfigurationName + CortexParameterSetNames.ByRadiusAuthentication,
10498
HelpMessage = "P2S External multiple radius servers.")]
10599
public PSRadiusServer[] RadiusServerList { get; set; }
106100

107101
[Parameter(
108102
Mandatory = false,
109-
ParameterSetName = CortexParameterSetNames.ByVpnServerConfigurationName + CortexParameterSetNames.ByRadiusAuthentication,
110103
HelpMessage = "A list of RadiusClientRootCertificate files' paths")]
111104
public string[] RadiusServerRootCertificateFilesList { get; set; }
112105

113106
[Parameter(
114107
Mandatory = false,
115-
ParameterSetName = CortexParameterSetNames.ByVpnServerConfigurationName + CortexParameterSetNames.ByRadiusAuthentication,
116108
HelpMessage = "A list of RadiusClientRootCertificate files' paths")]
117109
public string[] RadiusClientRootCertificateFilesList { get; set; }
118110

119111
[Parameter(
120112
Mandatory = false,
121-
ParameterSetName = CortexParameterSetNames.ByVpnServerConfigurationName + CortexParameterSetNames.ByAadAuthentication,
122113
HelpMessage = "AAD tenant for P2S AAD authentication.")]
123114
[ValidateNotNullOrEmpty]
124115
public string AadTenant { get; set; }
125116

126117
[Parameter(
127118
Mandatory = false,
128-
ParameterSetName = CortexParameterSetNames.ByVpnServerConfigurationName + CortexParameterSetNames.ByAadAuthentication,
129119
HelpMessage = "AAD audience for P2S AAD authentication.")]
130120
[ValidateNotNullOrEmpty]
131121
public string AadAudience { get; set; }
132122

133123

134124
[Parameter(
135125
Mandatory = false,
136-
ParameterSetName = CortexParameterSetNames.ByVpnServerConfigurationName + CortexParameterSetNames.ByAadAuthentication,
137126
HelpMessage = "AAD issuer for P2S AAD authentication.")]
138127
[ValidateNotNullOrEmpty]
139128
public string AadIssuer { get; set; }

0 commit comments

Comments
 (0)