HHH-11467 Replace incorrect use of StringHelper.WHITESPACE with single space.

mrotteveel · mrotteveel · commit 3c26ae7302f5 · 2017-02-07T16:48:10.000+01:00
This prevents an issue with Firebird where formfeed (\f or 0x0c) is not considered valid whitespace in a query.
diff --git a/hibernate-core/src/main/java/org/hibernate/cfg/annotations/CollectionBinder.java b/hibernate-core/src/main/java/org/hibernate/cfg/annotations/CollectionBinder.java
@@ -960,9 +960,9 @@ private void bindFilters(boolean hasAssociationTable) {
 			String clause = whereOnCollection.clause();
 			if ( StringHelper.isNotEmpty( clause ) ) {
 				if ( whereBuffer.length() > 0 ) {
-					whereBuffer.append( StringHelper.WHITESPACE );
+					whereBuffer.append( ' ' );
 					whereBuffer.append( Junction.Nature.AND.getOperator() );
-					whereBuffer.append( StringHelper.WHITESPACE );
+					whereBuffer.append( ' ' );
 				}
 				whereBuffer.append( clause );
 			}

Original file line number	Diff line number	Diff line change
`@@ -960,9 +960,9 @@ private void bindFilters(boolean hasAssociationTable) {`
`960`	`960`	`String clause = whereOnCollection.clause();`
`961`	`961`	`if ( StringHelper.isNotEmpty( clause ) ) {`
`962`	`962`	`if ( whereBuffer.length() > 0 ) {`
`963`		`- whereBuffer.append( StringHelper.WHITESPACE );`
	`963`	`+ whereBuffer.append( ' ' );`
`964`	`964`	`whereBuffer.append( Junction.Nature.AND.getOperator() );`
`965`		`- whereBuffer.append( StringHelper.WHITESPACE );`
	`965`	`+ whereBuffer.append( ' ' );`
`966`	`966`	`}`
`967`	`967`	`whereBuffer.append( clause );`
`968`	`968`	`}`