Skip to content

Commit 7275f16

Browse files
dreab8beikov
authored andcommitted
Re-enabled additional tests
1 parent 0c96fd7 commit 7275f16

File tree

1 file changed

+16
-25
lines changed

1 file changed

+16
-25
lines changed

hibernate-core/src/test_legacy/org/hibernate/test/locking/warning/LockNoneWarmingTest.java renamed to hibernate-core/src/test/java/org/hibernate/orm/test/locking/warning/LockNoneWarmingTest.java

Lines changed: 16 additions & 25 deletions
Original file line numberDiff line numberDiff line change
@@ -4,55 +4,48 @@
44
* License: GNU Lesser General Public License (LGPL), version 2.1 or later.
55
* See the lgpl.txt file in the root directory or <http://www.gnu.org/licenses/lgpl-2.1.html>.
66
*/
7-
package org.hibernate.test.locking.warning;
7+
package org.hibernate.orm.test.locking.warning;
88

9+
import java.io.Serializable;
10+
import java.util.HashSet;
11+
import java.util.Set;
912
import javax.persistence.Entity;
1013
import javax.persistence.FetchType;
1114
import javax.persistence.Id;
1215
import javax.persistence.ManyToOne;
1316
import javax.persistence.OneToMany;
1417
import javax.persistence.Table;
15-
import java.io.Serializable;
16-
import java.util.HashSet;
17-
import java.util.Set;
18-
19-
import org.jboss.byteman.contrib.bmunit.BMRule;
20-
import org.jboss.byteman.contrib.bmunit.BMRules;
21-
import org.jboss.byteman.contrib.bmunit.BMUnitRunner;
22-
23-
import org.jboss.logging.Logger;
2418

2519
import org.hibernate.LockMode;
2620
import org.hibernate.Session;
2721
import org.hibernate.internal.CoreMessageLogger;
28-
import org.hibernate.loader.Loader;
2922
import org.hibernate.query.Query;
3023

31-
import org.junit.After;
32-
import org.junit.Before;
33-
import org.junit.Rule;
34-
import org.junit.Test;
35-
import org.junit.runner.RunWith;
36-
3724
import org.hibernate.testing.TestForIssue;
3825
import org.hibernate.testing.junit4.BaseCoreFunctionalTestCase;
3926
import org.hibernate.testing.logger.LoggerInspectionRule;
4027
import org.hibernate.testing.logger.Triggerable;
4128
import org.hibernate.testing.transaction.TransactionUtil;
29+
import org.junit.After;
30+
import org.junit.Before;
31+
import org.junit.Rule;
32+
import org.junit.Test;
33+
34+
import org.jboss.logging.Logger;
4235

4336
import static org.junit.Assert.assertFalse;
4437

4538
/**
4639
* @author Andrea Boriero
4740
*/
4841
@TestForIssue(jiraKey = "HHH-10513")
49-
@RunWith(BMUnitRunner.class)
5042
public class LockNoneWarmingTest extends BaseCoreFunctionalTestCase {
5143

5244
private Triggerable triggerable;
45+
5346
@Rule
5447
public LoggerInspectionRule logInspection = new LoggerInspectionRule(
55-
Logger.getMessageLogger( CoreMessageLogger.class, Loader.class.getName() )
48+
Logger.getMessageLogger( CoreMessageLogger.class, LockNoneWarmingTest.class.getName() )
5649
);
5750

5851
@Override
@@ -81,12 +74,6 @@ public void tearDown(){
8174
}
8275

8376
@Test
84-
@BMRules(rules = {
85-
@BMRule(targetClass = "org.hibernate.dialect.Dialect",
86-
targetMethod = "useFollowOnLocking",
87-
action = "return true",
88-
name = "H2DialectUseFollowOnLocking")
89-
})
9077
public void testQuerySetLockModeNONEDoNotLogAWarnMessageWhenTheDialectUseFollowOnLockingIsTrue() {
9178
try (Session s = openSession();) {
9279
final Query query = s.createQuery( "from Item i join i.bids b where name = :name" );
@@ -104,6 +91,8 @@ public static class Item implements Serializable {
10491
@Id
10592
String name;
10693

94+
String comment;
95+
10796
@OneToMany(mappedBy = "item", fetch = FetchType.EAGER)
10897
Set<Bid> bids = new HashSet<Bid>();
10998
}
@@ -117,5 +106,7 @@ public static class Bid implements Serializable {
117106
@Id
118107
@ManyToOne
119108
Item item;
109+
110+
String comment;
120111
}
121112
}

0 commit comments

Comments
 (0)