HHH-11456 - SequenceHiLoGeneratorTest fails due to wrong select string on SQL Server

Author: istraka

hibernate-core/src/test/java/org/hibernate/id/SequenceHiLoGeneratorTest.java

@@ -8,7 +8,6 @@
 
 import java.util.Properties;
 
-import org.hibernate.Session;
 import org.hibernate.Transaction;
 import org.hibernate.boot.Metadata;
 import org.hibernate.boot.MetadataSources;
@@ -88,45 +87,48 @@ public void tearDown() throws Exception {
 	@Test
 	public void testHiLoAlgorithm() {
 		sessionImpl = (SessionImpl) sessionFactory.openSession();
-
-		// ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
-		// historically the hilo generators skipped the initial block of values;
-		// so the first generated id value is maxlo + 1, here be 4
-		assertEquals( 4L, generateValue() );
-		// which should also perform the first read on the sequence which should set it to its "start with" value (1)
-		assertEquals( 1L, extractSequenceValue() );
-
-		// ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
-		assertEquals( 5L, generateValue() );
-		assertEquals( 1L, extractSequenceValue() );
-
-		// ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
-		assertEquals( 6L, generateValue() );
-		assertEquals( 1L, extractSequenceValue() );
-
-		// ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
-		assertEquals( 7L, generateValue() );
-		// unlike the newer strategies, the db value will not get update here. It gets updated on the next invocation
-		// afterQuery a clock over
-		assertEquals( 1L, extractSequenceValue() );
-
-		// ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
-		assertEquals( 8L, generateValue() );
-		// this should force an increment in the sequence value
-		assertEquals( 2L, extractSequenceValue() );
-
-		((Session) sessionImpl).close();
+		try {
+			// ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
+			// historically the hilo generators skipped the initial block of values;
+			// so the first generated id value is maxlo + 1, here be 4
+			assertEquals(4L, generateValue());
+			// which should also perform the first read on the sequence which should set it to its "start with" value (1)
+			assertEquals(1L, extractSequenceValue());
+
+			// ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
+			assertEquals(5L, generateValue());
+			assertEquals(1L, extractSequenceValue());
+
+			// ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
+			assertEquals(6L, generateValue());
+			assertEquals(1L, extractSequenceValue());
+
+			// ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
+			assertEquals(7L, generateValue());
+			// unlike the newer strategies, the db value will not get update here. It gets updated on the next invocation
+			// afterQuery a clock over
+			assertEquals(1L, extractSequenceValue());
+
+			// ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
+			assertEquals(8L, generateValue());
+			// this should force an increment in the sequence value
+			assertEquals(2L, extractSequenceValue());
+		} finally {
+			sessionImpl.close();
+		}
 	}
 
 	private long extractSequenceValue() {
 		return sequenceValueExtractor.extractSequenceValue( sessionImpl );
 	}
 
 	private long generateValue() {
-		Long generatedValue;
-		Transaction transaction = ((Session) sessionImpl).beginTransaction();
-		generatedValue = (Long) generator.generate( sessionImpl, null );
-		transaction.commit();
-		return generatedValue.longValue();
+		Transaction transaction =  sessionImpl.beginTransaction();
+		try {
+			return  (Long) generator.generate( sessionImpl, null );
+		}
+		finally {
+			transaction.commit();
+		}
 	}
 }

hibernate-core/src/test/java/org/hibernate/id/SequenceValueExtractor.java

@@ -43,7 +43,7 @@ else if ( dialect instanceof Oracle8iDialect ) {
 			queryString = "select " + sequenceName + ".currval from dual";
 		}
 		else if ( dialect instanceof SQLServer2012Dialect ) {
-			queryString = "SELECT CONVERT(varchar(200), Current_value) FROM SYS.Sequences WHERE name = '" + sequenceName + "'";
+			queryString = "SELECT CONVERT(varchar(200), Current_value) FROM sys.sequences WHERE name = '" + sequenceName + "'";
 		}
 		else if ( dialect instanceof HSQLDialect ) {