Skip to content

Commit dafdd03

Browse files
authored
Merge pull request #194 from highcharts-for-python/develop
PR for v.1.9.2
2 parents 0f3a4af + 9d37de4 commit dafdd03

File tree

4 files changed

+18
-3
lines changed

4 files changed

+18
-3
lines changed

CHANGES.rst

Lines changed: 10 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,14 @@
11

2+
Release 1.9.2
3+
=========================================
4+
5+
* **BUGFIX:** Resolved over-broad False-y validation of ``PieDataLabel.distance`` to allow for ``0``
6+
values. Closes #192.
7+
* **BUGFIX:** Fixed over-broad False-y validation of ``Tooltip.header_format`` to allow for empty string
8+
values, bringing it in line with ``Tooltip.footer_format``. Closes #193.
9+
10+
----
11+
212
Release 1.9.1
313
=========================================
414

highcharts_core/__version__.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
__version__ = '1.9.1'
1+
__version__ = '1.9.2'

highcharts_core/options/tooltips.py

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -438,7 +438,10 @@ def header_format(self) -> Optional[str]:
438438

439439
@header_format.setter
440440
def header_format(self, value):
441-
self._header_format = validators.string(value, allow_empty = True)
441+
if value == '':
442+
self._header_format = value
443+
else:
444+
self._header_format = validators.string(value, allow_empty = True)
442445

443446
@property
444447
def header_shape(self) -> Optional[str]:

highcharts_core/utility_classes/data_labels.py

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -946,7 +946,7 @@ def distance(self) -> Optional[int | float | Decimal | str]:
946946

947947
@distance.setter
948948
def distance(self, value):
949-
if not value:
949+
if value is None:
950950
self._distance = None
951951
else:
952952
try:
@@ -955,6 +955,8 @@ def distance(self, value):
955955
if not isinstance(value, str):
956956
raise errors.HighchartsValueError(f'distance must be a number or a string, but received '
957957
f'{type(value).__name__}.')
958+
if value == '':
959+
value = None
958960

959961
self._distance = value
960962

0 commit comments

Comments
 (0)