Skip to content

Commit 3c605e3

Browse files
committed
ci: apply review comments on patch upload
1 parent 776110d commit 3c605e3

File tree

2 files changed

+4
-3
lines changed

2 files changed

+4
-3
lines changed

.github/workflows/regression-tests.yml

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@ on:
77
workflow_dispatch:
88

99
jobs:
10-
regression-tests-linux-mac:
10+
regression-tests:
1111
name: Run on ${{ matrix.os }} using ${{ matrix.compiler }}
1212
runs-on: ${{ matrix.os }}
1313
env:
@@ -49,3 +49,4 @@ jobs:
4949
with:
5050
name: ${{ matrix.compiler }}-patch.diff
5151
path: regression-tests/${{ matrix.compiler }}-patch.diff
52+
if-no-files-found: ignore

regression-tests/run-tests.sh

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -42,7 +42,7 @@ check_file () {
4242
diff_output=$(git diff --ignore-cr-at-eol -- "$file")
4343
if [[ -n "$diff_output" ]]; then
4444
echo " Non-matching $description:"
45-
printf "\n$diff_output\n\n"
45+
printf "\n$diff_output\n\n" | tee -a "$cxx_compiler-patch.diff"
4646
failure=1
4747
fi
4848
fi
@@ -195,7 +195,7 @@ for test_file in $tests; do
195195
# The source is temporarily copied to avoid issues with bash paths in cl.exe
196196
(cd $exec_out_dir; \
197197
cp ../../$expected_src $generated_cpp_name;
198-
$compiler_cmd "$test_bin" \
198+
$compiler_cmd"$test_bin" \
199199
$generated_cpp_name \
200200
> $generated_cpp_name.output 2>&1)
201201
compilation_result=$?

0 commit comments

Comments
 (0)