refactor(parse): consider the case of missing equal in initializer (#562)

Author: JohelEGP

regression-tests/pure2-bugfix-for-declaration-equal-error.cpp2

@@ -0,0 +1 @@
+main: () { }

regression-tests/test-results/pure2-bugfix-for-declaration-equal-error.cpp2.output

@@ -0,0 +1,5 @@
+pure2-bugfix-for-declaration-equal-error.cpp2...
+pure2-bugfix-for-declaration-equal-error.cpp2(1,10): error: missing semicolon at end of declaration or equal at start of initializer (at '{')
+pure2-bugfix-for-declaration-equal-error.cpp2(1,1): error: unexpected text at end of Cpp2 code section (at 'main')
+pure2-bugfix-for-declaration-equal-error.cpp2(1,0): error: parse failed for section starting here
+

source/parse.h

@@ -721,7 +721,7 @@ struct postfix_expression_node
         if (ops.empty()) {
             return false;
         } else {
-            return (ops.front().op->type() == lexeme::Ampersand 
+            return (ops.front().op->type() == lexeme::Ampersand
                     || ops.front().op->type() == lexeme::Tilde);
         }
     }
@@ -3993,7 +3993,7 @@ class parser
             //      || curr().type() == lexeme::LeftBrace
             )
         {
-            bool inside_initializer = ( 
+            bool inside_initializer = (
                 peek(-1) && peek(-1)->type() == lexeme::Assignment
             );
             auto open_paren = &curr();
@@ -4015,12 +4015,12 @@ class parser
             next();
             if (
                    curr().type() != lexeme::Semicolon
-                && curr().type() != lexeme::RightParen 
-                && curr().type() != lexeme::RightBracket 
+                && curr().type() != lexeme::RightParen
+                && curr().type() != lexeme::RightBracket
                 && curr().type() != lexeme::Comma
             ) {
                 expr_list->inside_initializer = false;
-            } 
+            }
             n->expr = std::move(expr_list);
             return n;
         }
@@ -4374,7 +4374,7 @@ class parser
     //G     shift-expression '<<' additive-expression
     //G     shift-expression '>>' additive-expression
     //G
-    auto shift_expression(bool allow_angle_operators = true) 
+    auto shift_expression(bool allow_angle_operators = true)
         -> auto
     {
         if (allow_angle_operators) {
@@ -4409,7 +4409,7 @@ class parser
     //G     shift-expression
     //G     compare-expression '<=>' shift-expression
     //G
-    auto compare_expression(bool allow_angle_operators = true) 
+    auto compare_expression(bool allow_angle_operators = true)
         -> auto
     {
         return binary_expression<compare_expression_node> (
@@ -4425,7 +4425,7 @@ class parser
     //G     relational-expression '<=' compare-expression
     //G     relational-expression '>=' compare-expression
     //G
-    auto relational_expression(bool allow_angle_operators = true) 
+    auto relational_expression(bool allow_angle_operators = true)
         -> auto
     {
         if (allow_angle_operators) {
@@ -4457,7 +4457,7 @@ class parser
     //G     equality-expression '==' relational-expression
     //G     equality-expression '!=' relational-expression
     //G
-    auto equality_expression(bool allow_angle_operators = true) 
+    auto equality_expression(bool allow_angle_operators = true)
         -> auto
     {
         return binary_expression<equality_expression_node> (
@@ -4470,7 +4470,7 @@ class parser
     //G     equality-expression
     //G     bit-and-expression '&' equality-expression
     //G
-    auto bit_and_expression(bool allow_angle_operators = true) 
+    auto bit_and_expression(bool allow_angle_operators = true)
         -> auto
     {
         return binary_expression<bit_and_expression_node> (
@@ -4483,7 +4483,7 @@ class parser
     //G     bit-and-expression
     //G     bit-xor-expression '^' bit-and-expression
     //G
-    auto bit_xor_expression(bool allow_angle_operators = true) 
+    auto bit_xor_expression(bool allow_angle_operators = true)
         -> auto
     {
         return binary_expression<bit_xor_expression_node> (
@@ -4496,7 +4496,7 @@ class parser
     //G     bit-xor-expression
     //G     bit-or-expression '|' bit-xor-expression
     //G
-    auto bit_or_expression(bool allow_angle_operators = true) 
+    auto bit_or_expression(bool allow_angle_operators = true)
         -> auto
     {
         return binary_expression<bit_or_expression_node> (
@@ -4509,7 +4509,7 @@ class parser
     //G     bit-or-expression
     //G     logical-and-expression '&&' bit-or-expression
     //G
-    auto logical_and_expression(bool allow_angle_operators = true) 
+    auto logical_and_expression(bool allow_angle_operators = true)
         -> auto
     {
         return binary_expression<logical_and_expression_node> (
@@ -4524,7 +4524,7 @@ class parser
     //G     logical-and-expression
     //G     logical-or-expression '||' logical-and-expression
     //G
-    auto logical_or_expression(bool allow_angle_operators = true) 
+    auto logical_or_expression(bool allow_angle_operators = true)
         -> auto
     {
         return binary_expression<logical_or_expression_node> (
@@ -4842,7 +4842,7 @@ class parser
 
             n->open_angle = curr().position();
             next();
-            
+
             auto term = unqualified_id_node::term{};
 
             do {
@@ -6433,7 +6433,7 @@ class parser
             }
             assert (n->is_type());
         }
-        
+
         //  Or a function type, declaring a function - and tell the function whether it's in a user-defined type
         else if (auto t = function_type(n.get(), named))
         {
@@ -6552,7 +6552,7 @@ class parser
             }
             // But if there isn't one and it was required, diagnose an error
             else if (semicolon_required) {
-                error("missing semicolon at end of declaration", true, {}, true);
+                error("missing semicolon at end of declaration or equal at start of initializer", true, {}, true);
                 return {};
             }
         }
@@ -6591,11 +6591,11 @@ class parser
                 )
             {
                 auto& type = std::get<declaration_node::an_object>(n->type);
-                // object initialized by the address of the curr() object 
+                // object initialized by the address of the curr() object
                 if (peek(1)->type() == lexeme::Ampersand) {
                     type->address_of = &curr();
                 }
-                // object initialized by (potentially multiple) dereference of the curr() object 
+                // object initialized by (potentially multiple) dereference of the curr() object
                 else if (peek(1)->type() == lexeme::Multiply) {
                     type->dereference_of = &curr();
                     for (int i = 1; peek(i)->type() == lexeme::Multiply; ++i)
@@ -6800,7 +6800,7 @@ class parser
                 return {};
             }
             if (
-                t->is_wildcard() 
+                t->is_wildcard()
                 || ( t->get_token() && t->get_token()->to_string(true) == "auto" )
             ) {
                 errors.emplace_back(