refactor: move has_template_parameter_named one scope up

Author: JohelEGP

source/cppfront.cpp

@@ -1730,20 +1730,24 @@ class cppfront
     }
 
 
+    auto has_template_parameter_named(declaration_node const& decl, token const& id)
+        -> bool
+    {
+        if (auto& params = decl.template_parameters) {
+            return std::any_of(params->parameters.begin(), params->parameters.end(), [&](auto& param) {
+                assert(param->has_name());
+                return *param->name() == id;
+            });
+        }
+        return false;
+    }
+
     auto is_template_parameter(token const& lookup_id)
         -> bool
     {
         // If any parent declaration
         return std::any_of(current_declarations.begin() + 1, current_declarations.end(), [&](auto& decl) {
-            // has a template parameter
-            if (auto& params = decl->template_parameters) {
-                return std::any_of(params->parameters.begin(), params->parameters.end(), [&](auto& param) {
-                    // of equal name.
-                    assert(param->has_name());
-                    return *param->name() == lookup_id;
-                });
-            }
-            return false;
+            return has_template_parameter_named(*decl, lookup_id);
         });
     }
 
@@ -3928,22 +3932,11 @@ class cppfront
         -> bool
     {
         assert( current_declarations.back() );
-        auto has_template_parameter = [&](declaration_node const* decl, token const* id) {
-            // If `decl` has a template parameter
-            if (auto& params = decl->template_parameters) {
-                return std::any_of(params->parameters.begin(), params->parameters.end(), [&](auto& param) {
-                    assert(param->has_name());
-                    // of equal name.
-                    return *param->name() == *id;
-                });
-            }
-            return false;
-        };
-        return has_template_parameter(current_declarations.back(), &lookup_id)
+        return has_template_parameter_named(*current_declarations.back(), lookup_id)
                || (
                    current_declarations.back()->parent_is_type()
                    && current_declarations.back()->has_name("operator=")
-                   && has_template_parameter(current_declarations.back()->get_parent(), &lookup_id)
+                   && has_template_parameter_named(*current_declarations.back()->get_parent(), lookup_id)
                   );
     }