refactor: work around sign compare warning

Author: JohelEGP

include/cpp2util.h

@@ -398,15 +398,16 @@ auto assert_not_null(auto&& p CPP2_SOURCE_LOCATION_PARAM_WITH_DEFAULT) -> declty
 //
 auto assert_in_bounds(auto&& x, auto&& arg CPP2_SOURCE_LOCATION_PARAM_WITH_DEFAULT) -> decltype(auto)
     requires (std::is_integral_v<CPP2_TYPEOF(arg)> &&
-             requires { std::ssize(x); x[arg]; std::begin(x) + 2; })
+             requires { std::size(x); std::ssize(x); x[arg]; std::begin(x) + 2; })
 {
-    Bounds.expects(0 <= arg && arg < std::ssize(x), "out of bounds access attempt detected" CPP2_SOURCE_LOCATION_ARG);
+    Bounds.expects(0 <= arg && arg < [&]() -> auto {
+        if constexpr (std::is_signed_v<CPP2_TYPEOF(arg)>) { return std::ssize(x); }
+        else { return std::size(x); }
+    }(), "out of bounds access attempt detected" CPP2_SOURCE_LOCATION_ARG);
     return CPP2_FORWARD(x) [ CPP2_FORWARD(arg) ];
 }
 
 auto assert_in_bounds(auto&& x, auto&& arg CPP2_SOURCE_LOCATION_PARAM_WITH_DEFAULT) -> decltype(auto)
-    requires (!(std::is_integral_v<CPP2_TYPEOF(arg)> &&
-             requires { std::ssize(x); x[arg]; std::begin(x) + 2; }))
 {
     return CPP2_FORWARD(x) [ CPP2_FORWARD(arg) ];
 }

regression-tests/test-results/clang-16/clang-version.output

@@ -0,0 +1,4 @@
+clang version 16.0.6 (https://github.com/llvm/llvm-project.git 7cbf1a2591520c2491aa35339f227775f4d3adf6)
+Target: x86_64-pc-linux-gnu
+Thread model: posix
+InstalledDir: /home/johel/root/clang/bin

regression-tests/test-results/clang-16/mixed-bounds-check.cpp.execution

@@ -0,0 +1,2 @@
+Bounds safety violation: out of bounds access attempt detected
+libc++abi: terminating

regression-tests/test-results/clang-16/mixed-bounds-safety-with-assert.cpp.execution

@@ -0,0 +1,2 @@
+Bounds safety violation
+libc++abi: terminating

regression-tests/test-results/clang-16/mixed-initialization-safety-3-contract-violation.cpp.execution

@@ -0,0 +1,2 @@
+Contract violation: fill: value must contain at least count elements
+libc++abi: terminating

regression-tests/test-results/clang-16/xyzzy

@@ -0,0 +1 @@
+Hello Fred with UFCS!