Skip to content

Commit f823181

Browse files
committed
added consts, fixed a initialization to pass clang-tidy
1 parent d747a88 commit f823181

File tree

8 files changed

+236
-234
lines changed

8 files changed

+236
-234
lines changed

.clang-tidy

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
Checks: 'misc-*, -misc-definitions-in-headers, -misc-non-private-member-variables-in-classes, -misc-no-recursion'
1+
Checks: 'misc-*, -misc-definitions-in-headers, -misc-non-private-member-variables-in-classes, -misc-no-recursion, -misc-include-cleaner, -misc-use-anonymous-namespace'

include/cpp2util.h

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1725,12 +1725,12 @@ inline constexpr auto is_narrowing_v =
17251725
// [dcl.init.list] 7.1
17261726
(std::is_floating_point_v<From> && std::is_integral_v<To>) ||
17271727
// [dcl.init.list] 7.2
1728-
(std::is_floating_point_v<From> && std::is_floating_point_v<To> && sizeof(From) > sizeof(To)) ||
1728+
(std::is_floating_point_v<From> && std::is_floating_point_v<To> && sizeof(From) > sizeof(To)) || // NOLINT(misc-redundant-expression)
17291729
// [dcl.init.list] 7.3
17301730
(std::is_integral_v<From> && std::is_floating_point_v<To>) ||
17311731
(std::is_enum_v<From> && std::is_floating_point_v<To>) ||
17321732
// [dcl.init.list] 7.4
1733-
(std::is_integral_v<From> && std::is_integral_v<To> && sizeof(From) > sizeof(To)) ||
1733+
(std::is_integral_v<From> && std::is_integral_v<To> && sizeof(From) > sizeof(To)) || // NOLINT(misc-redundant-expression)
17341734
(std::is_enum_v<From> && std::is_integral_v<To> && sizeof(From) > sizeof(To)) ||
17351735
// [dcl.init.list] 7.5
17361736
(std::is_pointer_v<From> && std::is_same_v<To, bool>)

source/common.h

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -880,8 +880,8 @@ class cmdline_processor
880880
-> void
881881
{
882882
help_requested = true;
883-
std::string_view a = __DATE__;
884-
std::string_view b = __TIME__;
883+
const std::string_view a = __DATE__;
884+
const std::string_view b = __TIME__;
885885
std::unordered_map<std::string_view, char> m = { {"Jan",'1'}, {"Feb",'2'}, {"Mar",'3'}, {"Apr",'4'}, {"May",'5'}, {"Jun",'6'}, {"Jul",'7'}, {"Aug",'8'}, {"Sep",'9'}, {"Oct",'A'}, {"Nov",'B'}, {"Dec",'C'} };
886886

887887
auto stamp = std::to_string(atoi(&a[9])-15);

source/parse.h

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -5947,7 +5947,7 @@ class parser
59475947
// Remember current position, because we may need to backtrack
59485948
auto start_pos = pos;
59495949

5950-
bool inside_initializer = (
5950+
const bool inside_initializer = (
59515951
peek(-1) && peek(-1)->type() == lexeme::Assignment
59525952
);
59535953
auto open_paren = &curr();
@@ -7909,7 +7909,7 @@ class parser
79097909
)
79107910
-> std::unique_ptr<compound_statement_node>
79117911
{
7912-
bool is_braced = curr().type() == lexeme::LeftBrace;
7912+
const bool is_braced = curr().type() == lexeme::LeftBrace;
79137913
if (
79147914
!is_braced
79157915
&& !allow_single_unbraced_statement

0 commit comments

Comments
 (0)