Remove unneeded tests.

TestUpdateElasticPoolAdvisor fails because the underlying service feature has been disabled.

TestElasticPoolMetricGet does not have any coverage of AzureRM.Sql cmdlets, it is intented to be testing metrics cmdlets.

Author: jaredmoo

src/ResourceManager/Sql/Commands.Sql.Test/Commands.Sql.Test.csproj

@@ -421,9 +421,6 @@
     <None Include="SessionRecords\Microsoft.Azure.Commands.Sql.Test.ScenarioTests.AdvisorTests\TestUpdateDatabaseAdvisor.json">
       <CopyToOutputDirectory>Always</CopyToOutputDirectory>
     </None>
-    <None Include="SessionRecords\Microsoft.Azure.Commands.Sql.Test.ScenarioTests.AdvisorTests\TestUpdateElasticPoolAdvisor.json">
-      <CopyToOutputDirectory>Always</CopyToOutputDirectory>
-    </None>
     <None Include="SessionRecords\Microsoft.Azure.Commands.Sql.Test.ScenarioTests.AdvisorTests\TestUpdateServerAdvisor.json">
       <CopyToOutputDirectory>Always</CopyToOutputDirectory>
     </None>
@@ -622,9 +619,6 @@
     <None Include="SessionRecords\Microsoft.Azure.Commands.Sql.Test.ScenarioTests.ElasticPoolCrudTests\TestElasticPoolGet.json">
       <CopyToOutputDirectory>Always</CopyToOutputDirectory>
     </None>
-    <None Include="SessionRecords\Microsoft.Azure.Commands.Sql.Test.ScenarioTests.ElasticPoolCrudTests\TestElasticPoolMetricGet.json">
-      <CopyToOutputDirectory>Always</CopyToOutputDirectory>
-    </None>
     <None Include="SessionRecords\Microsoft.Azure.Commands.Sql.Test.ScenarioTests.ElasticPoolCrudTests\TestElasticPoolRemove.json">
       <CopyToOutputDirectory>Always</CopyToOutputDirectory>
     </None>

src/ResourceManager/Sql/Commands.Sql.Test/ScenarioTests/AdvisorTests.cs

@@ -113,13 +113,6 @@ public void TestGetElasticPoolAdvisor()
             RunPowerShellTest("Test-GetElasticPoolAdvisor");
         }
 
-        [Fact(Skip = "Fails when run live due to HTTP 500 error on PATCH .../Microsoft.Sql/servers/{serverName}/elasticPools/{poolName}/advisors/CreateIndex?api-version=2015-05-01-preview")]
-        [Trait(Category.AcceptanceType, Category.CheckIn)]
-        public void TestUpdateElasticPoolAdvisor()
-        {
-            RunPowerShellTest("Test-UpdateElasticPoolAdvisor");
-        }
-
         #endregion
     }
 }

src/ResourceManager/Sql/Commands.Sql.Test/ScenarioTests/AdvisorTests.ps1

@@ -336,35 +336,6 @@ function Test-GetElasticPoolAdvisor
 	}
 }
 
-<#
-	.SYNOPSIS
-	Tests updating a elastic pool advisor
-#>
-function Test-UpdateElasticPoolAdvisor
-{
-	# Setup
-	$rg = Create-ResourceGroupForTest
-	$ep = SetupElasticPool $rg
-
-	try
-	{
-		$response = Set-AzureRmSqlElasticPoolAdvisorAutoExecuteStatus `
-			-ResourceGroupName $ep.ResourceGroupName `
-			-ServerName $ep.ServerName `
-			-ElasticPoolName $ep.ElasticPoolName `
-			-AdvisorName CreateIndex `
-			-AutoExecuteStatus Disabled
-		Assert-NotNull $response
-		ValidateElasticPool $response $ep
-		ValidateAdvisorProperties $response
-	}
-	finally
-	{
-		# Cleanup
-		Remove-ResourceGroupForTest $rg
-	}
-}
-
 <#
 	.SYNOPSIS
 	Setup Server for tests

src/ResourceManager/Sql/Commands.Sql.Test/ScenarioTests/ElasticPoolCrudTests.cs

@@ -13,10 +13,8 @@
 // ----------------------------------------------------------------------------------
 
 using Microsoft.Azure.Commands.ScenarioTest.SqlTests;
-using Microsoft.Azure.ServiceManagemenet.Common.Models;
-using Microsoft.Azure.Test.HttpRecorder;
 using Microsoft.WindowsAzure.Commands.ScenarioTest;
-using Microsoft.WindowsAzure.Commands.Utilities.Common;
+using RestTestFramework = Microsoft.Rest.ClientRuntime.Azure.TestFramework;
 using Xunit;
 using Xunit.Abstractions;
 
@@ -49,17 +47,6 @@ public void TestElasticPoolGet()
             RunPowerShellTest("Test-GetElasticPool");
         }
 
-        [Fact]
-        [Trait(Category.AcceptanceType, Category.CheckIn)]
-        public void TestElasticPoolMetricGet()
-        {
-            // Test cannot be re-recorded because it has hardcoded server name
-            if (TestMockSupport.RunningMocked)
-            {
-                RunPowerShellTest("Test-GetElasticPoolMetric");
-            }
-        }
-
         [Fact]
         [Trait(Category.AcceptanceType, Category.CheckIn)]
         public void TestElasticPoolRemove()

src/ResourceManager/Sql/Commands.Sql.Test/ScenarioTests/ElasticPoolCrudTests.ps1

@@ -146,33 +146,6 @@ function Test-GetElasticPool
     }
 }
 
-<# 
-    .SYNOPSIS
-    Tests getting an elastic pool metric
-#>
-function Test-GetElasticPoolMetric
-{
-    # This test requires that an elastic pool has been created and has metrics ready
-    # To prevent requiring putting something like a Sleep(10 minutes) in the code
-    # this test requires the server/elastic pool be pre-created with metrics data available.
-    
-    # Setup and retrieve the existing pool
-    $rgName = "test-group"
-    $serverName = "groupserver1"
-    $elasticPoolName = "testpool2"
-
-    $ep1 = Get-AzureRmSqlElasticPool  -ServerName $serverName -ResourceGroupName $rgName `
-        -ElasticPoolName $elasticPoolName
-    Assert-NotNull $ep1
-    
-    # Get pool metrics with all values
-    # Introducing breaking change that requires -MetricNames csv-list as parameter for this call (disabling this part of the test as done before)
-    #$metrics = $ep1 | Get-AzureRmMetric -TimeGrain "0:5:0" -StartTime "2015-04-22T16:00:00Z" -EndTime "2015-04-22T17:00:00Z"
-    #Assert-NotNull $metrics
-    #Assert-True { $metrics.Count -gt 0 }
-}
-
-
 <# 
     .SYNOPSIS
     Tests removing an elastic pool