Merge pull request #308 from viananth/ten-sub

Add warning to New-AzsSubscription and Get-AzureRmOffer cmdlets

Author: markcowl

src/StackAdmin/AzureStackAdmin/Commands.AzureStackAdmin/Microsoft.Subscriptions/Offers/GetOffer.cs

@@ -70,6 +70,9 @@ public class GetOffer : AdminApiCmdlet
         /// </summary>
         protected override void ExecuteCore()
         {
+            // note: this command should be deprecated
+            WriteWarning("Get-AzureRmOffer cmdlet will be deprecated and moved to a different module in a future release.");
+
             if (this.Managed.IsPresent)
             {
                  this.WriteWarning("The switch parameter Managed will be deprecated in a future release. Please use the cmdlet Get-AzsManagedOffer instead");

src/StackAdmin/AzureStackAdmin/Commands.AzureStackAdmin/Microsoft.Subscriptions/Subscriptions/NewSubscription.cs

@@ -90,10 +90,8 @@ protected SubscriptionDefinition GetSubscriptionDefinition()
         /// </summary>
         protected override void ExecuteCore()
         {
-            if (this.MyInvocation.InvocationName.Equals("New-AzureRmTenantSubscription", StringComparison.OrdinalIgnoreCase))
-            {
-                this.WriteWarning("Alias New-AzureRmTenantSubscription will be deprecated in a future release. Please use the cmdlet name New-AzsSubscription instead");
-            }
+            // note: this command should be deprecated
+            WriteWarning("New-AzsSubscription cmdlet will be deprecated and moved to a different module in a future release.");
 
             if (ShouldProcess(this.SubscriptionId, VerbsCommon.New))
             {