Skip to content

Commit 14556fd

Browse files
committed
Make radius server address mandatory in Radius Server parameter set
1 parent 1f7c269 commit 14556fd

File tree

3 files changed

+39
-3
lines changed

3 files changed

+39
-3
lines changed

src/ResourceManager/Network/Commands.Network/VirtualNetworkGateway/NewAzureVirtualNetworkGatewayCommand.cs

Lines changed: 19 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -38,20 +38,38 @@ public class NewAzureVirtualNetworkGatewayCommand : VirtualNetworkGatewayBaseCmd
3838
[Parameter(
3939
Mandatory = true,
4040
ValueFromPipelineByPropertyName = true,
41+
ParameterSetName = VirtualNetworkGatewayParameterSets.RadiusServerConfiguration,
42+
HelpMessage = "The resource name.")]
43+
[Parameter(
44+
Mandatory = true,
45+
ValueFromPipelineByPropertyName = true,
46+
ParameterSetName = VirtualNetworkGatewayParameterSets.Default,
4147
HelpMessage = "The resource name.")]
4248
[ValidateNotNullOrEmpty]
4349
public virtual string Name { get; set; }
4450

4551
[Parameter(
4652
Mandatory = true,
4753
ValueFromPipelineByPropertyName = true,
54+
ParameterSetName = VirtualNetworkGatewayParameterSets.RadiusServerConfiguration,
55+
HelpMessage = "The resource group name.")]
56+
[Parameter(
57+
Mandatory = true,
58+
ValueFromPipelineByPropertyName = true,
59+
ParameterSetName = VirtualNetworkGatewayParameterSets.Default,
4860
HelpMessage = "The resource group name.")]
4961
[ValidateNotNullOrEmpty]
5062
public virtual string ResourceGroupName { get; set; }
5163

5264
[Parameter(
5365
Mandatory = true,
5466
ValueFromPipelineByPropertyName = true,
67+
ParameterSetName = VirtualNetworkGatewayParameterSets.RadiusServerConfiguration,
68+
HelpMessage = "location.")]
69+
[Parameter(
70+
Mandatory = true,
71+
ValueFromPipelineByPropertyName = true,
72+
ParameterSetName = VirtualNetworkGatewayParameterSets.Default,
5573
HelpMessage = "location.")]
5674
[ValidateNotNullOrEmpty]
5775
public string Location { get; set; }
@@ -169,7 +187,7 @@ public class NewAzureVirtualNetworkGatewayCommand : VirtualNetworkGatewayBaseCmd
169187
public SwitchParameter Force { get; set; }
170188

171189
[Parameter(
172-
Mandatory = false,
190+
Mandatory = true,
173191
ValueFromPipelineByPropertyName = true,
174192
ParameterSetName = VirtualNetworkGatewayParameterSets.RadiusServerConfiguration,
175193
HelpMessage = "P2S External Radius server address.")]

src/ResourceManager/Network/Commands.Network/VirtualNetworkGateway/SetAzureVirtualNetworkGatewayVpnClientConfig.cs

Lines changed: 13 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -36,19 +36,31 @@ public class SetAzureVirtualNetworkGatewayVpnClientConfigCommand : VirtualNetwor
3636
[Parameter(
3737
Mandatory = true,
3838
ValueFromPipeline = true,
39+
ParameterSetName = VirtualNetworkGatewayParameterSets.RadiusServerConfiguration,
40+
HelpMessage = "The VirtualNetworkGateway")]
41+
[Parameter(
42+
Mandatory = true,
43+
ValueFromPipeline = true,
44+
ParameterSetName = VirtualNetworkGatewayParameterSets.Default,
3945
HelpMessage = "The VirtualNetworkGateway")]
4046
[ValidateNotNull]
4147
public PSVirtualNetworkGateway VirtualNetworkGateway { get; set; }
4248

4349
[Parameter(
4450
Mandatory = true,
4551
ValueFromPipelineByPropertyName = true,
52+
ParameterSetName = VirtualNetworkGatewayParameterSets.RadiusServerConfiguration,
53+
HelpMessage = "P2S VpnClient AddressPool")]
54+
[Parameter(
55+
Mandatory = true,
56+
ValueFromPipelineByPropertyName = true,
57+
ParameterSetName = VirtualNetworkGatewayParameterSets.Default,
4658
HelpMessage = "P2S VpnClient AddressPool")]
4759
[ValidateNotNullOrEmpty]
4860
public List<string> VpnClientAddressPool { get; set; }
4961

5062
[Parameter(
51-
Mandatory = false,
63+
Mandatory = true,
5264
ValueFromPipelineByPropertyName = true,
5365
ParameterSetName = VirtualNetworkGatewayParameterSets.RadiusServerConfiguration,
5466
HelpMessage = "P2S External Radius server address.")]

src/ResourceManager/Network/Commands.Network/VirtualNetworkGateway/UpdateAzureVirtualNetworkGatewayCommand.cs

Lines changed: 7 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -34,6 +34,12 @@ public class SetAzureVirtualNetworkGatewayCommand : VirtualNetworkGatewayBaseCmd
3434
{
3535
[Parameter(
3636
Mandatory = true,
37+
ParameterSetName = VirtualNetworkGatewayParameterSets.RadiusServerConfiguration,
38+
ValueFromPipeline = true,
39+
HelpMessage = "The virtual network gateway object to base modifications off of. This can be retrieved using Get-AzureRmVirtualNetworkGateway")]
40+
[Parameter(
41+
Mandatory = true,
42+
ParameterSetName = VirtualNetworkGatewayParameterSets.Default,
3743
ValueFromPipeline = true,
3844
HelpMessage = "The virtual network gateway object to base modifications off of. This can be retrieved using Get-AzureRmVirtualNetworkGateway")]
3945
public PSVirtualNetworkGateway VirtualNetworkGateway { get; set; }
@@ -111,7 +117,7 @@ public class SetAzureVirtualNetworkGatewayCommand : VirtualNetworkGatewayBaseCmd
111117
public SwitchParameter DisableActiveActiveFeature { get; set; }
112118

113119
[Parameter(
114-
Mandatory = false,
120+
Mandatory = true,
115121
ValueFromPipelineByPropertyName = true,
116122
ParameterSetName = VirtualNetworkGatewayParameterSets.RadiusServerConfiguration,
117123
HelpMessage = "P2S External Radius server address.")]

0 commit comments

Comments
 (0)