Skip to content

Commit 1c859e3

Browse files
fanglfangl
authored andcommitted
Resolve comments
1 parent 16e0ab7 commit 1c859e3

File tree

2 files changed

+25
-5
lines changed

2 files changed

+25
-5
lines changed

src/ResourceManager/Sql/Commands.Sql.Test/ScenarioTests/Common.ps1

Lines changed: 15 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -515,4 +515,19 @@ function Get-SqlSyncMemberTestEnvironmentParameters ()
515515
return @{ syncDirection = "Bidirectional";
516516
databaseType = "AzureSqlDatabase";
517517
}
518+
}
519+
520+
<#
521+
.SYNOPSIS
522+
Gets dns name according to environment
523+
#>
524+
function Get-DNSNameBasedOnEnvironment ()
525+
{
526+
$connectingString = [System.Environment]::GetEnvironmentVariable("TEST_CSM_ORGID_AUTHENTICATION")
527+
$parsedString = [Microsoft.Azure.Test.TestUtilities]::ParseConnectionString($connectingString)
528+
$environment = $parsedString[[Microsoft.Azure.Test.TestEnvironment]::EnvironmentKey]
529+
if ($environment -eq "Prod"){
530+
return ".database.windows.net"
531+
}
532+
return ".sqltest-eg1.mscds.com"
518533
}

src/ResourceManager/Sql/Commands.Sql.Test/ScenarioTests/DataSyncTests.ps1

Lines changed: 10 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -357,7 +357,8 @@ function Test-CreateSyncMember
357357
# Setup
358358
$rg = Create-ResourceGroupForTest
359359
$server = Create-ServerForTest $rg "12.0" "West US 2"
360-
$serverName = "$($server.ServerName).sqltest-eg1.mscds.com"
360+
$serverDNS = Get-DNSNameBasedOnEnvironment
361+
$serverName = $server.ServerName + $serverDNS
361362
$credential = Get-ServerCredential
362363
$databaseName1 = Get-DatabaseName
363364
$db1 = New-AzureRmSqlDatabase -ResourceGroupName $rg.ResourceGroupName -ServerName $server.ServerName -DatabaseName $databaseName1
@@ -405,7 +406,8 @@ function Test-GetAndListSyncMembers
405406
# Setup
406407
$rg = Create-ResourceGroupForTest
407408
$server = Create-ServerForTest $rg "12.0" "West US 2"
408-
$serverName = "$($server.ServerName).sqltest-eg1.mscds.com"
409+
$serverDNS = Get-DNSNameBasedOnEnvironment
410+
$serverName = $server.ServerName + $serverDNS
409411
$credential = Get-ServerCredential
410412
$databaseName1 = Get-DatabaseName
411413
$db1 = New-AzureRmSqlDatabase -ResourceGroupName $rg.ResourceGroupName -ServerName $server.ServerName -DatabaseName $databaseName1
@@ -462,7 +464,8 @@ function Test-UpdateSyncMember
462464
# Setup
463465
$rg = Create-ResourceGroupForTest
464466
$server = Create-ServerForTest $rg "12.0" "West US 2"
465-
$serverName = "$($server.ServerName).sqltest-eg1.mscds.com"
467+
$serverDNS = Get-DNSNameBasedOnEnvironment
468+
$serverName = $server.ServerName + $serverDNS
466469
$credential = Get-ServerCredential
467470
$databaseName1 = Get-DatabaseName
468471
$db1 = New-AzureRmSqlDatabase -ResourceGroupName $rg.ResourceGroupName -ServerName $server.ServerName -DatabaseName $databaseName1
@@ -512,7 +515,8 @@ function Test-RefreshAndGetSyncMemberSchema
512515
# Setup
513516
$rg = Create-ResourceGroupForTest
514517
$server = Create-ServerForTest $rg "12.0" "West US 2"
515-
$serverName = "$($server.ServerName).sqltest-eg1.mscds.com"
518+
$serverDNS = Get-DNSNameBasedOnEnvironment
519+
$serverName = $server.ServerName + $serverDNS
516520
$credential = Get-ServerCredential
517521
$databaseName1 = Get-DatabaseName
518522
$db1 = New-AzureRmSqlDatabase -ResourceGroupName $rg.ResourceGroupName -ServerName $server.ServerName -DatabaseName $databaseName1
@@ -560,7 +564,8 @@ function Test-RemoveSyncMember
560564
# Setup
561565
$rg = Create-ResourceGroupForTest
562566
$server = Create-ServerForTest $rg "12.0" "West US 2"
563-
$serverName = "$($server.ServerName).sqltest-eg1.mscds.com"
567+
$serverDNS = Get-DNSNameBasedOnEnvironment
568+
$serverName = $server.ServerName + $serverDNS
564569
$credential = Get-ServerCredential
565570
$databaseName1 = Get-DatabaseName
566571
$db1 = New-AzureRmSqlDatabase -ResourceGroupName $rg.ResourceGroupName -ServerName $server.ServerName -DatabaseName $databaseName1

0 commit comments

Comments
 (0)