Skip to content

Commit 20cda8b

Browse files
author
Siddharth Chatrola
committed
Code review comment fixed
1 parent 625d268 commit 20cda8b

File tree

2 files changed

+10
-10
lines changed

2 files changed

+10
-10
lines changed

‎src/ResourceManager/RedisCache/Commands.RedisCache/Microsoft.Azure.Commands.RedisCache.dll-Help.xml

Lines changed: 9 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -305,7 +305,7 @@
305305
<command:parameter required="false" variableLength="false" globbing="false" pipelineInput="True (ByPropertyName)" position="named" aliases="">
306306
<maml:name>Size</maml:name>
307307
<maml:description>
308-
<maml:para>Size of the redis cache. The default value is 1GB or C1. Possible values are P1,P2, P3, P4, C0, C1, C2, C3, C4, C5, C6, 250MB, 1GB, 2.5GB, 6GB, 13GB, 26GB, 53GB.</maml:para>
308+
<maml:para>Size of the redis cache. The default value is 1GB or C1. Possible values are P1, P2, P3, P4, C0, C1, C2, C3, C4, C5, C6, 250MB, 1GB, 2.5GB, 6GB, 13GB, 26GB, 53GB.</maml:para>
309309
</maml:description>
310310
<command:parameterValue required="true" variableLength="false">String</command:parameterValue>
311311
</command:parameter>
@@ -326,7 +326,7 @@
326326
<command:parameter required="false" variableLength="false" globbing="false" pipelineInput="True (ByPropertyName)" position="named" aliases="">
327327
<maml:name>RedisConfiguration</maml:name>
328328
<maml:description>
329-
<maml:para> All Redis Configuration Settings. Few possible keys: maxmemory-delta, maxmemory-policy, notify-keyspace-events, maxmemory-samples, slowlog-log-slower-than, slowlog-max-len, list-max-ziplist-entries, list-max-ziplist-value, hash-max-ziplist-entries, hash-max-ziplist-value, set-max-intset-entries, zset-max-ziplist-entries, zset-max-ziplist-value etc. </maml:para>
329+
<maml:para> All Redis Configuration Settings. Few possible keys: rdb-backup-enabled, rdb-storage-connection-string, rdb-backup-frequency, maxmemory-delta, maxmemory-policy, notify-keyspace-events, maxmemory-samples, slowlog-log-slower-than, slowlog-max-len, list-max-ziplist-entries, list-max-ziplist-value, hash-max-ziplist-entries, hash-max-ziplist-value, set-max-intset-entries, zset-max-ziplist-entries, zset-max-ziplist-value etc. </maml:para>
330330
</maml:description>
331331
<command:parameterValue required="true" variableLength="false">Hashtable</command:parameterValue>
332332
</command:parameter>
@@ -422,7 +422,7 @@
422422
<command:parameter required="false" variableLength="false" globbing="false" pipelineInput="True (ByPropertyName)" position="named" aliases="">
423423
<maml:name>Size</maml:name>
424424
<maml:description>
425-
<maml:para>Size of the redis cache. The default value is 1GB or C1. Possible values are P1,P2, P3, P4, C0, C1, C2, C3, C4, C5, C6, 250MB, 1GB, 2.5GB, 6GB, 13GB, 26GB, 53GB.</maml:para>
425+
<maml:para>Size of the redis cache. The default value is 1GB or C1. Possible values are P1, P2, P3, P4, C0, C1, C2, C3, C4, C5, C6, 250MB, 1GB, 2.5GB, 6GB, 13GB, 26GB, 53GB.</maml:para>
426426
</maml:description>
427427
<command:parameterValue required="true" variableLength="false">String</command:parameterValue>
428428
<dev:type>
@@ -458,7 +458,7 @@
458458
<command:parameter required="false" variableLength="false" globbing="false" pipelineInput="True (ByPropertyName)" position="named" aliases="">
459459
<maml:name>RedisConfiguration</maml:name>
460460
<maml:description>
461-
<maml:para> All Redis Configuration Settings. Few possible keys: maxmemory-delta, maxmemory-policy, notify-keyspace-events, maxmemory-samples, slowlog-log-slower-than, slowlog-max-len, list-max-ziplist-entries, list-max-ziplist-value, hash-max-ziplist-entries, hash-max-ziplist-value, set-max-intset-entries, zset-max-ziplist-entries, zset-max-ziplist-value etc. </maml:para>
461+
<maml:para> All Redis Configuration Settings. Few possible keys: rdb-backup-enabled, rdb-storage-connection-string, rdb-backup-frequency, maxmemory-delta, maxmemory-policy, notify-keyspace-events, maxmemory-samples, slowlog-log-slower-than, slowlog-max-len, list-max-ziplist-entries, list-max-ziplist-value, hash-max-ziplist-entries, hash-max-ziplist-value, set-max-intset-entries, zset-max-ziplist-entries, zset-max-ziplist-value etc. </maml:para>
462462
</maml:description>
463463
<command:parameterValue required="true" variableLength="false">Hashtable</command:parameterValue>
464464
<dev:type>
@@ -1172,7 +1172,7 @@
11721172
<command:parameter required="false" variableLength="false" globbing="false" pipelineInput="True (ByPropertyName)" position="named" aliases="">
11731173
<maml:name>Size</maml:name>
11741174
<maml:description>
1175-
<maml:para>Size of the redis cache. The default value is 1GB or C1. Possible values are P1,P2, P3, P4, C0, C1, C2, C3, C4, C5, C6, 250MB, 1GB, 2.5GB, 6GB, 13GB, 26GB, 53GB.</maml:para>
1175+
<maml:para>Size of the redis cache. The default value is 1GB or C1. Possible values are P1, P2, P3, P4, C0, C1, C2, C3, C4, C5, C6, 250MB, 1GB, 2.5GB, 6GB, 13GB, 26GB, 53GB.</maml:para>
11761176
</maml:description>
11771177
<command:parameterValue required="true" variableLength="false">String</command:parameterValue>
11781178
</command:parameter>
@@ -1193,7 +1193,7 @@
11931193
<command:parameter required="false" variableLength="false" globbing="false" pipelineInput="True (ByPropertyName)" position="named" aliases="">
11941194
<maml:name>RedisConfiguration</maml:name>
11951195
<maml:description>
1196-
<maml:para> All Redis Configuration Settings. Few possible keys: maxmemory-delta, maxmemory-policy, notify-keyspace-events, maxmemory-samples, slowlog-log-slower-than, slowlog-max-len, list-max-ziplist-entries, list-max-ziplist-value, hash-max-ziplist-entries, hash-max-ziplist-value, set-max-intset-entries, zset-max-ziplist-entries, zset-max-ziplist-value etc. </maml:para>
1196+
<maml:para> All Redis Configuration Settings. Few possible keys: rdb-backup-enabled, rdb-storage-connection-string, rdb-backup-frequency, maxmemory-delta, maxmemory-policy, notify-keyspace-events, maxmemory-samples, slowlog-log-slower-than, slowlog-max-len, list-max-ziplist-entries, list-max-ziplist-value, hash-max-ziplist-entries, hash-max-ziplist-value, set-max-intset-entries, zset-max-ziplist-entries, zset-max-ziplist-value etc. </maml:para>
11971197
</maml:description>
11981198
<command:parameterValue required="true" variableLength="false">Hashtable</command:parameterValue>
11991199
</command:parameter>
@@ -1243,7 +1243,7 @@
12431243
<command:parameter required="false" variableLength="false" globbing="false" pipelineInput="True (ByPropertyName)" position="named" aliases="">
12441244
<maml:name>Size</maml:name>
12451245
<maml:description>
1246-
<maml:para>Size of the redis cache. Possible values are C0, C1, C2, C3, C4, C5, C6, 250MB, 1GB, 2.5GB, 6GB, 13GB, 26GB, 53GB.</maml:para>
1246+
<maml:para>Size of the redis cache. The default value is 1GB or C1. Possible values are P1,P2, P3, P4, C0, C1, C2, C3, C4, C5, C6, 250MB, 1GB, 2.5GB, 6GB, 13GB, 26GB, 53GB.</maml:para>
12471247
</maml:description>
12481248
<command:parameterValue required="true" variableLength="false">String</command:parameterValue>
12491249
<dev:type>
@@ -1255,7 +1255,7 @@
12551255
<command:parameter required="false" variableLength="false" globbing="false" pipelineInput="True (ByPropertyName)" position="named" aliases="">
12561256
<maml:name>Sku</maml:name>
12571257
<maml:description>
1258-
<maml:para>Sku of the redis cache. Possible values are Basic and Standard.</maml:para>
1258+
<maml:para>Sku of redis cache. The default value is Standard. Possible values are Basic, Standard and Premium.</maml:para>
12591259
</maml:description>
12601260
<command:parameterValue required="true" variableLength="false">String</command:parameterValue>
12611261
<dev:type>
@@ -1279,7 +1279,7 @@
12791279
<command:parameter required="false" variableLength="false" globbing="false" pipelineInput="True (ByPropertyName)" position="named" aliases="">
12801280
<maml:name>RedisConfiguration</maml:name>
12811281
<maml:description>
1282-
<maml:para> All Redis Configuration Settings. Few possible keys: maxmemory-delta, maxmemory-policy, notify-keyspace-events, maxmemory-samples, slowlog-log-slower-than, slowlog-max-len, list-max-ziplist-entries, list-max-ziplist-value, hash-max-ziplist-entries, hash-max-ziplist-value, set-max-intset-entries, zset-max-ziplist-entries, zset-max-ziplist-value etc. </maml:para>
1282+
<maml:para> All Redis Configuration Settings. Few possible keys: rdb-backup-enabled, rdb-storage-connection-string, rdb-backup-frequency, maxmemory-delta, maxmemory-policy, notify-keyspace-events, maxmemory-samples, slowlog-log-slower-than, slowlog-max-len, list-max-ziplist-entries, list-max-ziplist-value, hash-max-ziplist-entries, hash-max-ziplist-value, set-max-intset-entries, zset-max-ziplist-entries, zset-max-ziplist-value etc. </maml:para>
12831283
</maml:description>
12841284
<command:parameterValue required="true" variableLength="false">Hashtable</command:parameterValue>
12851285
<dev:type>

‎src/ResourceManager/RedisCache/Commands.RedisCache/Models/SizeConverter.cs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -113,7 +113,7 @@ public static string GetSizeInUserSpecificFormat(string skuFamily, int skuCapaci
113113
{
114114
return skuStringToActualSize[sizeConstant];
115115
}
116-
return GB1;
116+
return null;
117117
}
118118
}
119119
}

0 commit comments

Comments
 (0)