ADL PowerShell updates for code freeze

Update to latest packages
Re-add support for Get/Set permissions
Re-add support for removing full ACLs
Update functionality of the ACL listing and setting logic

Missed a save.

Author: begoldsm

src/ResourceManager/DataLakeAnalytics/Commands.DataLakeAnalytics/Commands/GetAzureRmDataLakeAnalyticsDataSource.cs

@@ -26,7 +26,7 @@ public class GetAzureDataLakeAnalyticsDataSource : DataLakeAnalyticsCmdletBase
     {
         internal const string DataLakeParameterSetName = "Get a Data Lake Store account";
         internal const string BlobParameterSetName = "Get a Blob storage account";
-        internal const string ListStorageParameterSetName = "List a data source";
+        internal const string ListStorageParameterSetName = "List all data sources";
 
         [Parameter(ValueFromPipelineByPropertyName = true, Position = 0, Mandatory = true,
             ParameterSetName = DataLakeParameterSetName, HelpMessage = "Name of the account to add the data source to.")

src/ResourceManager/DataLakeAnalytics/Commands.DataLakeAnalytics/Commands/NewAzureRmDataLakeAnalyticsCatalogSecret.cs

@@ -55,7 +55,7 @@ public class NewAzureDataLakeAnalyticsCatalogSecret : DataLakeAnalyticsCmdletBas
 
         [Parameter(ValueFromPipelineByPropertyName = true, ParameterSetName = BaseParameterSetName, Position = 3,
             Mandatory = true, HelpMessage = "The host of the database to connect to in the format 'myhost.dns.com'.")]
-        public string Host { get; set; }
+        public string DatabaseHost { get; set; }
 
         [Parameter(ValueFromPipelineByPropertyName = true, ParameterSetName = BaseParameterSetName, Position = 4,
             Mandatory = true, HelpMessage = "The Port associated with the host for the database to connect to.")]
@@ -68,7 +68,7 @@ public override void ExecuteCmdlet()
                 WriteWarning(string.Format(Resources.NoPortSpecified, Uri));
             }
 
-            var toUse = Uri ?? new Uri(string.Format("https://{0}:{1}", Host, Port));
+            var toUse = Uri ?? new Uri(string.Format("https://{0}:{1}", DatabaseHost, Port));
 
             WriteObject(DataLakeAnalyticsClient.CreateSecret(Account, DatabaseName, Secret.UserName,
                 Secret.GetNetworkCredential().Password, toUse.AbsoluteUri));

src/ResourceManager/DataLakeAnalytics/Commands.DataLakeAnalytics/Commands/SetAzureRmDataLakeAnalyticsCatalogSecret.cs

@@ -55,7 +55,7 @@ public class SetAzureDataLakeAnalyticsCatalogSecret : DataLakeAnalyticsCmdletBas
 
         [Parameter(ValueFromPipelineByPropertyName = true, ParameterSetName = BaseParameterSetName, Position = 3,
             Mandatory = true, HelpMessage = "The host of the database to connect to in the format 'myhost.dns.com'.")]
-        public string Host { get; set; }
+        public string DatabaseHost { get; set; }
 
         [Parameter(ValueFromPipelineByPropertyName = true, ParameterSetName = BaseParameterSetName, Position = 4,
             Mandatory = true, HelpMessage = "The Port associated with the host for the database to connect to.")]
@@ -68,7 +68,7 @@ public override void ExecuteCmdlet()
                 WriteWarning(string.Format(Resources.NoPortSpecified, Uri));
             }
 
-            var toUse = Uri ?? new Uri(string.Format("https://{0}:{1}", Host, Port));
+            var toUse = Uri ?? new Uri(string.Format("https://{0}:{1}", DatabaseHost, Port));
 
             WriteObject(DataLakeAnalyticsClient.UpdateSecret(Account, DatabaseName, Secret.UserName,
                 Secret.GetNetworkCredential().Password, toUse.AbsoluteUri));

src/ResourceManager/DataLakeStore/Commands.DataLakeStore/Commands.DataLakeStore.csproj

@@ -152,7 +152,7 @@
     <Compile Include="Models\DataLakeStoreFileSystemClient.cs" />
     <Compile Include="Models\DataLakeStoreFileSystemCmdletBase.cs" />
     <Compile Include="Models\DataLakeStoreItem.cs" />
-    <Compile Include="Models\DataLakeStoreItemAcl.cs" />
+    <Compile Include="Models\DataLakeStoreItemAce.cs" />
     <Compile Include="Models\DataLakeStoreItemPermissionInstance.cs" />
     <Compile Include="Models\DataLakeStorePathInstance.cs" />
     <Compile Include="Models\GlobalMembers.cs" />

src/ResourceManager/DataLakeStore/Commands.DataLakeStore/Commands/GetAzureRmDataLakeStoreItemAcl.cs

@@ -17,7 +17,7 @@
 
 namespace Microsoft.Azure.Commands.DataLakeStore
 {
-    [Cmdlet(VerbsCommon.Get, "AzureRmDataLakeStoreItemAcl"), OutputType(typeof(DataLakeStoreItemAcl))]
+    [Cmdlet(VerbsCommon.Get, "AzureRmDataLakeStoreItemAcl"), OutputType(typeof(DataLakeStoreItemAce))]
     [Alias("Get-AdlStoreItemAcl")]
     public class GetAzureDataLakeStoreItemAcl : DataLakeStoreFileSystemCmdletBase
     {
@@ -37,9 +37,8 @@ public class GetAzureDataLakeStoreItemAcl : DataLakeStoreFileSystemCmdletBase
 
         public override void ExecuteCmdlet()
         {
-            var toReturn = new DataLakeStoreItemAcl();
-            toReturn.InitializeAces(DataLakeStoreFileSystemClient.GetAclStatus(Path.TransformedPath, Account));
-            WriteObject(toReturn);
+            var toReturn = DataLakeStoreItemAce.GetAclFromStatus(DataLakeStoreFileSystemClient.GetAclStatus(Path.TransformedPath, Account));
+            WriteObject(toReturn, true);
         }
     }
 }

src/ResourceManager/DataLakeStore/Commands.DataLakeStore/Commands/GetAzureRmDataLakeStoreItemPermissions.cs

@@ -17,8 +17,8 @@
 
 namespace Microsoft.Azure.Commands.DataLakeStore
 {
-    // [Cmdlet(VerbsCommon.Get, "AzureRmDataLakeStoreItemPermissions"), OutputType(typeof(DataLakeStoreItemPermissionInstance))]
-    // [Alias("Get-AdlStoreItemPermissions")]
+    [Cmdlet(VerbsCommon.Get, "AzureRmDataLakeStoreItemPermissions"), OutputType(typeof(string))]
+    [Alias("Get-AdlStoreItemPermissions")]
     public class GetAzureDataLakeStoreItemPermissions : DataLakeStoreFileSystemCmdletBase
     {
         [Parameter(ValueFromPipelineByPropertyName = true, Position = 0, Mandatory = true,
@@ -37,9 +37,7 @@ public class GetAzureDataLakeStoreItemPermissions : DataLakeStoreFileSystemCmdle
 
         public override void ExecuteCmdlet()
         {
-            WriteObject(
-                DataLakeStoreItemPermissionInstance.Parse(
-                    DataLakeStoreFileSystemClient.GetFileStatus(Path.TransformedPath, Account).Permission));
+            WriteObject(DataLakeStoreFileSystemClient.GetFileStatus(Path.TransformedPath, Account).Permission);
         }
     }
 }

src/ResourceManager/DataLakeStore/Commands.DataLakeStore/Commands/RemoveAzureRmDataLakeStoreItemAcl.cs

@@ -18,8 +18,8 @@
 
 namespace Microsoft.Azure.Commands.DataLakeStore
 {
-    //[Cmdlet(VerbsCommon.Remove, "AzureRmDataLakeStoreItemAcl"), OutputType(typeof (bool))]
-    //[Alias("Remove-AdlStoreItemAcl")]
+    [Cmdlet(VerbsCommon.Remove, "AzureRmDataLakeStoreItemAcl"), OutputType(typeof (bool))]
+    [Alias("Remove-AdlStoreItemAcl")]
     public class RemoveAzureDataLakeStoreItemAcl : DataLakeStoreFileSystemCmdletBase
     {
         [Parameter(ValueFromPipelineByPropertyName = true, Position = 0, Mandatory = true,

src/ResourceManager/DataLakeStore/Commands.DataLakeStore/Commands/RemoveAzureRmDataLakeStoreItemAclEntry.cs

@@ -57,7 +57,7 @@ public class RemoveAzureDataLakeStoreItemAclEntry : DataLakeStoreFileSystemCmdle
                 "The ACL spec containing the entries to remove. These entries MUST exist in the ACL spec for the file already. This can be a modified ACL from Get-AzureDataLakeStoreItemAcl or it can be the string " +
                 " representation of an ACL as defined in the apache webhdfs specification. Note that this is only supported for named ACEs." +
                 "This cmdlet is not to be used for setting the owner or owning group.")]
-        public DataLakeStoreItemAcl Acl { get; set; }
+        public DataLakeStoreItemAce[] Acl { get; set; }
 
         [Parameter(ValueFromPipelineByPropertyName = true, ParameterSetName = SpecificAceParameterSetName, Position = 2,
             Mandatory = true, HelpMessage = "Indicates the type of ACE to remove (user, group, mask, other)")]
@@ -76,10 +76,10 @@ public class RemoveAzureDataLakeStoreItemAclEntry : DataLakeStoreFileSystemCmdle
         public SwitchParameter Default { get; set; }
 
         public override void ExecuteCmdlet()
-        {
+        {   
             var aclSpec = ParameterSetName.Equals(BaseParameterSetName)
-                ? Acl.GetAclSpec(false)
-                : string.Format("{0}{1}:{2}", Default ? "default:" : string.Empty, AceType, Id).ToLowerInvariant();
+                ? DataLakeStoreItemAce.GetAclSpec(Acl, false)
+                : string.Format("{0}{1}{2}", Default ? "default:" : string.Empty, AceType + ":", !Default ?  Id.ToString() : string.Empty).ToLowerInvariant();
             ConfirmAction(
                 string.Format(Resources.RemoveDataLakeStoreItemAcl, string.Empty, Path.OriginalPath),
                 Path.OriginalPath,

src/ResourceManager/DataLakeStore/Commands.DataLakeStore/Commands/SetAzureRmDataLakeStoreItemAcl.cs

@@ -43,7 +43,7 @@ public class SetAzureDataLakeStoreItemAcl : DataLakeStoreFileSystemCmdletBase
                 "The ACL to set. This can be a modified ACL from Get-AzureDataLakeStoreItemAcl or it can be the string " +
                 " representation of an ACL as defined in the apache webhdfs specification. Note that this is only supported for named ACEs." +
                 "This cmdlet is not to be used for setting the owner or owning group.")]
-        public DataLakeStoreItemAcl Acl { get; set; }
+        public DataLakeStoreItemAce[] Acl { get; set; }
 
         public override void ExecuteCmdlet()
         {
@@ -52,8 +52,7 @@ public override void ExecuteCmdlet()
                 Path.OriginalPath,
                 () =>
                     DataLakeStoreFileSystemClient.SetAcl(Path.TransformedPath, Account,
-                        Acl.GetAclSpec()));
-
+                        DataLakeStoreItemAce.GetAclSpec(Acl)));
         }
     }
 }

src/ResourceManager/DataLakeStore/Commands.DataLakeStore/Commands/SetAzureRmDataLakeStoreItemAclEntry.cs

@@ -56,7 +56,7 @@ public class SetAzureDataLakeStoreItemAclEntry : DataLakeStoreFileSystemCmdletBa
                 "The ACL spec containing the entries to set. These entries MUST exist in the ACL spec for the file already. This can be a modified ACL from Get-AzureDataLakeStoreItemAcl or it can be the string " +
                 " representation of an ACL as defined in the apache webhdfs specification. Note that this is only supported for named ACEs." +
                 "This cmdlet is not to be used for setting the owner or owning group.")]
-        public DataLakeStoreItemAcl Acl { get; set; }
+        public DataLakeStoreItemAce[] Acl { get; set; }
 
         [Parameter(ValueFromPipelineByPropertyName = true, ParameterSetName = SpecificAceParameterSetName, Position = 2,
             Mandatory = true, HelpMessage = "Indicates the type of ACE to set (user, group, mask, other)")]
@@ -82,7 +82,7 @@ public class SetAzureDataLakeStoreItemAclEntry : DataLakeStoreFileSystemCmdletBa
         public override void ExecuteCmdlet()
         {
             var aclSpec = ParameterSetName.Equals(BaseParameterSetName)
-                ? Acl.GetAclSpec()
+                ? DataLakeStoreItemAce.GetAclSpec(Acl)
                 : string.Format("{0}{1}:{2}:{3}", Default ? "default:" : string.Empty, AceType, Id,
                     DataLakeStoreItemPermissionInstance.GetPermissionString(Permissions)).ToLowerInvariant();
 

src/ResourceManager/DataLakeStore/Commands.DataLakeStore/Commands/SetAzureRmDataLakeStoreItemPermissions.cs

@@ -17,8 +17,8 @@
 
 namespace Microsoft.Azure.Commands.DataLakeStore
 {
-    // [Cmdlet(VerbsCommon.Set, "AzureRmDataLakeStoreItemPermissions"), OutputType(typeof(bool))]
-    // [Alias("Set-AdlStoreItemPermissions")]
+    [Cmdlet(VerbsCommon.Set, "AzureRmDataLakeStoreItemPermissions"), OutputType(typeof(bool))]
+    [Alias("Set-AdlStoreItemPermissions")]
     public class SetAzureDataLakeStoreItemPermissions : DataLakeStoreFileSystemCmdletBase
     {
         [Parameter(ValueFromPipelineByPropertyName = true, Position = 0, Mandatory = true,
@@ -39,12 +39,12 @@ public class SetAzureDataLakeStoreItemPermissions : DataLakeStoreFileSystemCmdle
             HelpMessage =
                 "The permissions to set for the file or folder. This can be expressed as an octal (e.g. '777') or as a friendly string (e.g. 'rwxrwxrwx')"
             )]
-        [ValidateNotNull]
-        public DataLakeStoreItemPermissionInstance Permissions { get; set; }
+        [ValidateRange(0, 1777)]
+        public int Permissions { get; set; }
 
         public override void ExecuteCmdlet()
         {
-            DataLakeStoreFileSystemClient.SetPermission(Path.TransformedPath, Account, Permissions.PermissionsOctal);
+            DataLakeStoreFileSystemClient.SetPermission(Path.TransformedPath, Account, Permissions.ToString());
             WriteObject(true);
         }
     }