Move environment variable declaration to test constructor from controller

cormacpayne · cormacpayne · commit 33c51f7def4d · 2017-08-07T09:21:59.000-07:00
diff --git a/src/ResourceManager/Profile/Commands.Profile.Test/ContextCmdletTests.cs b/src/ResourceManager/Profile/Commands.Profile.Test/ContextCmdletTests.cs
@@ -24,6 +24,8 @@
 using Xunit;
 using Xunit.Abstractions;
 using Microsoft.Azure.Commands.Common.Authentication.Abstractions;
+using System;
+using Microsoft.WindowsAzure.Commands.Common;
 
 namespace Microsoft.Azure.Commands.ResourceManager.Profile.Test
 {
@@ -42,6 +44,7 @@ public ContextCmdletTests(ITestOutputHelper output)
             AzureSession.Instance.DataStore = dataStore;
             commandRuntimeMock = new MockCommandRuntime();
             AzureSession.Instance.AuthenticationFactory = new MockTokenAuthenticationFactory();
+            Environment.SetEnvironmentVariable(AzurePSDataCollectionProfile.EnvironmentVariableName, "false");
         }
 
         [Fact]
diff --git a/src/ResourceManager/Profile/Commands.Profile.Test/ProfileController.cs b/src/ResourceManager/Profile/Commands.Profile.Test/ProfileController.cs
@@ -108,7 +108,7 @@ private void RunPsTestWorkflow(
                     helper.RMResourceModule,
                     helper.RMResourceManagerStartup,
                     helper.RMInsightsModule);
-                Environment.SetEnvironmentVariable(AzurePSDataCollectionProfile.EnvironmentVariableName, "false");
+
                 try
                 {
                     if (scriptBuilder != null)

Original file line number	Diff line number	Diff line change
`@@ -24,6 +24,8 @@`
`24`	`24`	`using Xunit;`
`25`	`25`	`using Xunit.Abstractions;`
`26`	`26`	`using Microsoft.Azure.Commands.Common.Authentication.Abstractions;`
	`27`	`+using System;`
	`28`	`+using Microsoft.WindowsAzure.Commands.Common;`
`27`	`29`
`28`	`30`	`namespace Microsoft.Azure.Commands.ResourceManager.Profile.Test`
`29`	`31`	`{`
`@@ -42,6 +44,7 @@ public ContextCmdletTests(ITestOutputHelper output)`
`42`	`44`	`AzureSession.Instance.DataStore = dataStore;`
`43`	`45`	`commandRuntimeMock = new MockCommandRuntime();`
`44`	`46`	`AzureSession.Instance.AuthenticationFactory = new MockTokenAuthenticationFactory();`
	`47`	`+ Environment.SetEnvironmentVariable(AzurePSDataCollectionProfile.EnvironmentVariableName, "false");`
`45`	`48`	`}`
`46`	`49`
`47`	`50`	`[Fact]`
Original file line number	Diff line number	Diff line change
`@@ -108,7 +108,7 @@ private void RunPsTestWorkflow(`
`108`	`108`	`helper.RMResourceModule,`
`109`	`109`	`helper.RMResourceManagerStartup,`
`110`	`110`	`helper.RMInsightsModule);`
`111`		`- Environment.SetEnvironmentVariable(AzurePSDataCollectionProfile.EnvironmentVariableName, "false");`
	`111`	`+`
`112`	`112`	`try`
`113`	`113`	`{`
`114`	`114`	`if (scriptBuilder != null)`