Merge pull request #274 from MabOneSdk/swatim-dev1

Adding strings to resource file for PsBackupProviderManager.cs

Author: swatimadhukargit

src/ResourceManager/RecoveryServices.Backup/Commands.RecoveryServices.Backup.Models/CommonModels/Enums.cs

@@ -30,7 +30,8 @@ public enum ContainerType
     public enum BackupManagementType
     {
         AzureVM = 1,
-        MARS
+        MARS,
+        SCDPM
     }
 
     public enum BackupEngineType

src/ResourceManager/RecoveryServices.Backup/Commands.RecoveryServices.Backup.Models/Properties/Resources.Designer.cs

@@ -419,4 +419,16 @@ Please contact Microsoft for further assistant.</value>
   <data name="GetRPErrorInputDatesShouldBeInUTC" xml:space="preserve">
     <value>Both EndDate and StartDate should be in UTC format</value>
   </data>
+  <data name="BackupManagementTypeNotExpectedForWorkloadType" xml:space="preserve">
+    <value>BackupManagementType is not expected for WorkloadType: {0}</value>
+  </data>
+  <data name="BackupManagementTypeRequiredForContainerType" xml:space="preserve">
+    <value>BackupManagementType provider for ContainerType {0} is incorrect.</value>
+  </data>
+  <data name="BackupManagementTypeRequiredForWorkloadType" xml:space="preserve">
+    <value>BackupManagementType is also required for WorkloadType: {0}</value>
+  </data>
+  <data name="UnsupportedContainerType" xml:space="preserve">
+    <value>Unsupported containerType: {0}</value>
+  </data>
 </root>

src/ResourceManager/RecoveryServices.Backup/Commands.RecoveryServices.Backup.Models/Properties/Resources.resx

@@ -14,6 +14,7 @@
 
 using Microsoft.Azure.Commands.RecoveryServices.Backup.Cmdlets.HydraAdapterNS;
 using Microsoft.Azure.Commands.RecoveryServices.Backup.Cmdlets.Models;
+using Microsoft.Azure.Commands.RecoveryServices.Backup.Properties;
 using System;
 using System.Collections.Generic;
 using System.Linq;
@@ -49,18 +50,10 @@ public IPsBackupProvider GetProviderInstance(ContainerType containerType, Backup
                     if (backupManagementType == BackupManagementType.MARS)
                         providerType = PsBackupProviderTypes.Mab;
                     else
-                        throw new ArgumentException(String.Format("BackupManagementType is required for ContainerType {1}.", backupManagementType.ToString(), containerType));
+                        throw new ArgumentException(String.Format(Resources.BackupManagementTypeRequiredForContainerType, containerType));
                     break;
-                //case ContainerType.AzureSqlContainer:
-                //    if (backupManagementType.HasValue)
-                //    {
-                //        throw new ArgumentException("BackupManagementType is not expected for ContainerType: " +
-                //                                     containerType.ToString());
-                //    }
-                //    providerType = PsBackupProviderTypes.AzureSql;
-                //    break;
                 default:
-                    throw new ArgumentException("Unsupported containerType: " + containerType.ToString());
+                    throw new ArgumentException(String.Format(Resources.UnsupportedContainerType, containerType.ToString()));
             }
 
             return GetProviderInstance(providerType);
@@ -81,8 +74,8 @@ public IPsBackupProvider GetProviderInstance(WorkloadType workloadType)
                     providerType = PsBackupProviderTypes.IaasVm;
                     break;
                 default:
-                    throw new ArgumentException("BackupManagementType is also required for WorkloadType: " +
-                                                     workloadType.ToString());
+                    throw new ArgumentException(String.Format(Resources.BackupManagementTypeRequiredForWorkloadType,
+                                                     workloadType.ToString()));
             }
 
             return GetProviderInstance(providerType);
@@ -104,13 +97,13 @@ public IPsBackupProvider GetProviderInstance(WorkloadType workloadType, BackupMa
                     if (backupManagementType.HasValue && backupManagementType != BackupManagementType.AzureVM)
                     {
                         // throw exception that it is not expected
-                        throw new ArgumentException("BackupManagementType is not expected for WorkloadType: " +
-                                                     workloadType.ToString());
+                        throw new ArgumentException(String.Format(Resources.BackupManagementTypeNotExpectedForWorkloadType, 
+                                                     workloadType.ToString()));
                     }
                     psProviderType = PsBackupProviderTypes.IaasVm;
                     break;
                 default:
-                    throw new ArgumentException("Unsupported workloadType: " + workloadType.ToString());
+                    throw new ArgumentException(String.Format(Resources.UnsupportedWorkloadTypeException, workloadType.ToString()));
             }
 
             return GetProviderInstance(psProviderType);