Update string parameter validation

Author: jasper-schneider

src/ResourceManager/Batch/Commands.Batch/Models/BatchClient.Jobs.cs

@@ -35,7 +35,7 @@ public IEnumerable<PSCloudJob> ListJobs(ListJobOptions options)
                 throw new ArgumentNullException("options");
             }
 
-            if (string.IsNullOrEmpty(options.WorkItemName) && options.WorkItem == null)
+            if (string.IsNullOrWhiteSpace(options.WorkItemName) && options.WorkItem == null)
             {
                 throw new ArgumentNullException(Resources.GBJ_NoWorkItem);    
             }
@@ -89,7 +89,7 @@ public void DeleteJob(RemoveJobParameters parameters)
             {
                 throw new ArgumentNullException("parameters");
             }
-            if ((string.IsNullOrEmpty(parameters.WorkItemName) || string.IsNullOrEmpty(parameters.JobName)) && parameters.Job == null)
+            if ((string.IsNullOrWhiteSpace(parameters.WorkItemName) || string.IsNullOrWhiteSpace(parameters.JobName)) && parameters.Job == null)
             {
                 throw new ArgumentException(Resources.RBJ_NoJobSpecified);
             }

src/ResourceManager/Batch/Commands.Batch/Models/BatchClient.Pools.cs

@@ -37,7 +37,7 @@ public IEnumerable<PSCloudPool> ListPools(ListPoolOptions options)
             }
 
             // Get the single Pool matching the specified name
-            if (!string.IsNullOrEmpty(options.PoolName))
+            if (!string.IsNullOrWhiteSpace(options.PoolName))
             {
                 WriteVerbose(string.Format(Resources.GBP_GetByName, options.PoolName));
                 using (IPoolManager poolManager = options.Context.BatchOMClient.OpenPoolManager())
@@ -83,7 +83,7 @@ public void CreatePool(NewPoolParameters parameters)
             {
                 throw new ArgumentNullException("parameters");
             }
-            if (string.IsNullOrEmpty(parameters.PoolName))
+            if (string.IsNullOrWhiteSpace(parameters.PoolName))
             {
                 throw new ArgumentNullException("PoolName");
             }
@@ -156,7 +156,7 @@ public void CreatePool(NewPoolParameters parameters)
         /// <param name="additionBehaviors">Additional client behaviors to perform</param>
         public void DeletePool(BatchAccountContext context, string poolName, IEnumerable<BatchClientBehavior> additionBehaviors = null)
         {
-            if (string.IsNullOrEmpty(poolName))
+            if (string.IsNullOrWhiteSpace(poolName))
             {
                 throw new ArgumentNullException("poolName");
             }

src/ResourceManager/Batch/Commands.Batch/Models/BatchClient.Tasks.cs

@@ -36,7 +36,7 @@ public IEnumerable<PSCloudTask> ListTasks(ListTaskOptions options)
                 throw new ArgumentNullException("options");
             }
 
-            if ((string.IsNullOrEmpty(options.WorkItemName) || string.IsNullOrEmpty(options.JobName)) && options.Job == null)
+            if ((string.IsNullOrWhiteSpace(options.WorkItemName) || string.IsNullOrWhiteSpace(options.JobName)) && options.Job == null)
             {
                 throw new ArgumentNullException(Resources.GBT_NoJob);
             }
@@ -98,11 +98,11 @@ public void CreateTask(NewTaskParameters parameters)
             {
                 throw new ArgumentNullException("parameters");
             }
-            if ((string.IsNullOrEmpty(parameters.WorkItemName) || string.IsNullOrEmpty(parameters.JobName)) && parameters.Job == null)
+            if ((string.IsNullOrWhiteSpace(parameters.WorkItemName) || string.IsNullOrWhiteSpace(parameters.JobName)) && parameters.Job == null)
             {
                 throw new ArgumentException(Resources.NBT_NoJobSpecified);
             }
-            if (string.IsNullOrEmpty(parameters.TaskName))
+            if (string.IsNullOrWhiteSpace(parameters.TaskName))
             {
                 throw new ArgumentNullException("TaskName");
             }
@@ -164,7 +164,7 @@ public void DeleteTask(RemoveTaskParameters parameters)
             {
                 throw new ArgumentNullException("parameters");
             }
-            if ((string.IsNullOrEmpty(parameters.WorkItemName) || string.IsNullOrEmpty(parameters.JobName) || string.IsNullOrEmpty(parameters.TaskName)) && parameters.Task == null)
+            if ((string.IsNullOrWhiteSpace(parameters.WorkItemName) || string.IsNullOrWhiteSpace(parameters.JobName) || string.IsNullOrWhiteSpace(parameters.TaskName)) && parameters.Task == null)
             {
                 throw new ArgumentException(Resources.RBT_NoTaskSpecified);
             }

src/ResourceManager/Batch/Commands.Batch/Models/BatchClient.WorkItems.cs

@@ -38,7 +38,7 @@ public IEnumerable<PSCloudWorkItem> ListWorkItems(ListWorkItemOptions options)
             }
 
             // Get the single WorkItem matching the specified name
-            if (!string.IsNullOrEmpty(options.WorkItemName))
+            if (!string.IsNullOrWhiteSpace(options.WorkItemName))
             {
                 WriteVerbose(string.Format(Resources.GBWI_GetByName, options.WorkItemName));
                 using (IWorkItemManager wiManager = options.Context.BatchOMClient.OpenWorkItemManager())
@@ -84,7 +84,7 @@ public void CreateWorkItem(NewWorkItemParameters parameters)
             {
                 throw new ArgumentNullException("parameters");
             }
-            if (string.IsNullOrEmpty(parameters.WorkItemName))
+            if (string.IsNullOrWhiteSpace(parameters.WorkItemName))
             {
                 throw new ArgumentNullException("WorkItemName");
             }
@@ -132,7 +132,7 @@ public void CreateWorkItem(NewWorkItemParameters parameters)
         /// <param name="additionBehaviors">Additional client behaviors to perform</param>
         public void DeleteWorkItem(BatchAccountContext context, string workItemName, IEnumerable<BatchClientBehavior> additionBehaviors = null)
         {
-            if (string.IsNullOrEmpty(workItemName))
+            if (string.IsNullOrWhiteSpace(workItemName))
             {
                 throw new ArgumentNullException("workItemName");
             }